[MIG] crm_claim: Migration to 10.0 #170
Conversation
cubells
force-pushed
the
10.0-mig-crm_claim
branch
2 times, most recently
from
d179033 to
110c33d
Compare
cubells
force-pushed
the
10.0-mig-crm_claim
branch
2 times, most recently
from
2dc1eb9 to
290ef5e
Compare
cubells
force-pushed
the
10.0-mig-crm_claim
branch
from
290ef5e to
c62a4d4
Compare
crm_claim/report/crm_claim_report.py
Outdated
|
|
||
| from odoo import fields, models, tools | ||
|
|
||
| AVAILABLE_PRIORITIES = [ |
There was a problem hiding this comment.
Put directly this on the field. I haven't seen this used in any other place. Am I right?
crm_claim/report/crm_claim_report.py
Outdated
|
|
||
| tools.drop_view_if_exists(self._cr, 'crm_claim_report') | ||
| self._cr.execute(""" | ||
| create or replace view crm_claim_report as ( |
There was a problem hiding this comment.
Please split this query to be inheritable.
|
@rafaelbn @luismontalba please review |
crm_claim/README.rst
Outdated
| * Go to new menu **CRM > Configuration > Claim > Categories** and create as | ||
| many categories as you need. | ||
| * Go to new menú **CRM > After Sale > Services > Stages** and create stages for | ||
| claims. |
There was a problem hiding this comment.
Sales > Configuration > Claim > Stages
There was a problem hiding this comment.
This menu exists if you have installed sales module. If not, correct menu is CRM > Configuration > Claim > Stages
This module only depends on sales_team.
| <field name="model">crm.claim.stage</field> | ||
| <field name="arch" type="xml"> | ||
| <tree string="Claim Stages"> | ||
| <field name="sequence"/> |
There was a problem hiding this comment.
A widget="handle" would fit here, don't you think?
| <form string="Claim Stage"> | ||
| <group col="4"> | ||
| <field name="name"/> | ||
| <field name="case_default"/> |
There was a problem hiding this comment.
Isn't it a little bit hard to know wich team a stage belongs to?
There was a problem hiding this comment.
You can't know which team a stage belongs to, because stage isn't a field of crm.team model.
Case_default is used to assign a default stage based on team to crm_claim
There was a problem hiding this comment.
@chienandalu I am agree with your point. We have to set case_default to True. To overcome these situation, we can visible Teams field into Stage. Afterwards above domain will works fine. I have created PR (#178) for that.
|
@max3903 there's still a comment unattended. Why do you merge? |
|
@pedrobaeza Sorry, I didn't see the pending comment. I saw the 2 approved reviews and the "needs review" tag. |
|
OK, let's see if there's something to change and if so, we propose a new PR. |
As crm_claim is not available in odoo v10.0, we migrate crm_claim to oca.
cc @Tecnativa