-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] crm_claim: Migration to 17.0 #594
Conversation
Please check CI |
1aa8a1c
to
901ec7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
901ec7f
to
b638ae0
Compare
Include record rule for multi-company.
1f70569
to
0022673
Compare
Squash administrive commits please @BernatObrador |
The Claim form's statusbar is intended to be clickable, but Odoo 13 is apparently no longer compatible with `clickable="True"`. Instead, either `clickable="1"` or `options="{'clickable': 1}"` must be used. Odoo core code uses the latter, so the Claim form has been updated to match core convention.
Currently translated at 100.0% (144 of 144 strings) Translation: crm-14.0/crm-14.0-crm_claim Translate-URL: https://translation.odoo-community.org/projects/crm-14-0/crm-14-0-crm_claim/de/
Currently translated at 100.0% (147 of 147 strings) Translation: crm-15.0/crm-15.0-crm_claim Translate-URL: https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-crm_claim/ca/
Currently translated at 100.0% (143 of 143 strings) Translation: crm-16.0/crm-16.0-crm_claim Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_claim/it/
Currently translated at 100.0% (143 of 143 strings) Translation: crm-16.0/crm-16.0-crm_claim Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_claim/es/
Currently translated at 100.0% (143 of 143 strings) Translation: crm-16.0/crm-16.0-crm_claim Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_claim/es/
Currently translated at 91.5% (130 of 142 strings) Translation: crm-16.0/crm-16.0-crm_claim Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_claim/fr_FR/
It's setting a context when creating records for the default team_id and it's not necessary, it's redundant because the team_id field already has a default that defines it. This code is not necessary. TT49102
…to claim form view TT46565
Currently translated at 16.1% (23 of 142 strings) Translation: crm-16.0/crm-16.0-crm_claim Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_claim/pt_BR/
0022673
to
629414f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested in runboat
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
@pedrobaeza Sorry for pinging you directly, is this ready to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot migration crm_claim
/ocabot merge nobump
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 0a0a5ec. Thanks a lot for contributing to OCA. ❤️ |
Module migrated to version 17.0
cc https://github.com/APSL 159308
@miquelalzanillas @lbarry-apsl @mpascuall @peluko00 @javierobcn @ppyczko please review