Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] crm_claim: Migration to 17.0 #594

Merged
merged 39 commits into from
Dec 10, 2024
Merged

Conversation

BernatObrador
Copy link

@BernatObrador BernatObrador commented Aug 8, 2024

@BernatObrador BernatObrador mentioned this pull request Aug 8, 2024
20 tasks
@pedrobaeza pedrobaeza mentioned this pull request Aug 8, 2024
@pedrobaeza
Copy link
Member

Please check CI

@BernatObrador BernatObrador force-pushed the 17.0-mig-crm_claim branch 2 times, most recently from 1aa8a1c to 901ec7f Compare August 8, 2024 11:03
Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BernatObrador BernatObrador force-pushed the 17.0-mig-crm_claim branch 2 times, most recently from 1f70569 to 0022673 Compare August 8, 2024 12:40
@peluko00
Copy link

peluko00 commented Aug 8, 2024

Squash administrive commits please @BernatObrador

flachica and others added 8 commits August 9, 2024 08:14
The Claim form's statusbar is intended to be clickable, but Odoo 13 is
apparently no longer compatible with `clickable="True"`. Instead, either
`clickable="1"` or `options="{'clickable': 1}"` must be used. Odoo core
code uses the latter, so the Claim form has been updated to match core
convention.
Currently translated at 100.0% (144 of 144 strings)

Translation: crm-14.0/crm-14.0-crm_claim
Translate-URL: https://translation.odoo-community.org/projects/crm-14-0/crm-14-0-crm_claim/de/
pere-aquarian and others added 15 commits August 9, 2024 08:14
Currently translated at 100.0% (147 of 147 strings)

Translation: crm-15.0/crm-15.0-crm_claim
Translate-URL: https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-crm_claim/ca/
Currently translated at 100.0% (143 of 143 strings)

Translation: crm-16.0/crm-16.0-crm_claim
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_claim/it/
Currently translated at 100.0% (143 of 143 strings)

Translation: crm-16.0/crm-16.0-crm_claim
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_claim/es/
Currently translated at 100.0% (143 of 143 strings)

Translation: crm-16.0/crm-16.0-crm_claim
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_claim/es/
Currently translated at 91.5% (130 of 142 strings)

Translation: crm-16.0/crm-16.0-crm_claim
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_claim/fr_FR/
It's setting a context when creating records for the default team_id and it's not necessary, it's redundant because the team_id field already has a default that defines it. This code is not necessary.

TT49102
Currently translated at 16.1% (23 of 142 strings)

Translation: crm-16.0/crm-16.0-crm_claim
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_claim/pt_BR/
Copy link

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

Copy link

github-actions bot commented Dec 8, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 8, 2024
@BernatObrador
Copy link
Author

@pedrobaeza Sorry for pinging you directly, is this ready to merge?

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot migration crm_claim
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Dec 10, 2024
@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-594-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0a0a5ec. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 4c4027d into OCA:17.0 Dec 10, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved merged 🎉 stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.