[17.0][IMP] crm_lead_code: space get removed when other view changes name field

[CRogos]

I have another module which extends the same view like this:

    <record id="crm_case_kanban_view_leads" model="ir.ui.view">
        <field name="name">crm.show.fields</field>
        <field name="model">crm.lead</field>
        <field name="inherit_id" ref="crm.crm_case_kanban_view_leads" />
        <field name="arch" type="xml">
            <field name="name" position="attributes">
                <attribute name="invisible">1</attribute>
            </field>
            <field name="name" position="after">
                <field name="display_name" />
            </field>
        </field>
    </record>

This causes that the space ( ) after the code field is somehow removed.

This change prevents this side effect.

[MohamedOsman7]

LGTM

[flotho]

Hi, thanks for this PR.
IMHO <span/> should be better

[CRogos]

<span/> does not add the extra SPACE.
Or is there a css class which we could apply?

[CRogos]

Ok found a solution: <span class="p-1" />
thank you for your feedback.

[flotho]

Hi,
Thanks, much better!

[CRogos]

@pedrobaeza would you merge?

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[pedrobaeza]

/ocabot merge minor

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-601-by-pedrobaeza-bump-minor, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 5aca41d. Thanks a lot for contributing to OCA. ❤️