-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] marketing_crm_partner: Migration to 17.0 #603
[17.0][MIG] marketing_crm_partner: Migration to 17.0 #603
Conversation
This module extends the functionality of the CRM to support having the tracking fields available in the partner and copy them there automatically when the partner is created from a lead/opportunity.
Method name has changed
Currently translated at 100.0% (9 of 9 strings) Translation: crm-11.0/crm-11.0-marketing_crm_partner Translate-URL: https://translation.odoo-community.org/projects/crm-11-0/crm-11-0-marketing_crm_partner/de/
Currently translated at 100.0% (9 of 9 strings) Translation: crm-11.0/crm-11.0-marketing_crm_partner Translate-URL: https://translation.odoo-community.org/projects/crm-11-0/crm-11-0-marketing_crm_partner/gl/
Currently translated at 100.0% (6 of 6 strings) Translation: crm-12.0/crm-12.0-marketing_crm_partner Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-marketing_crm_partner/pt_BR/
Since odoo/odoo@e183393, we need to reassign the partner to the lead, as the method doesn't do it by itself.
Currently translated at 100.0% (6 of 6 strings) Translation: crm-12.0/crm-12.0-marketing_crm_partner Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-marketing_crm_partner/hr/
Currently translated at 100.0% (6 of 6 strings) Translation: crm-12.0/crm-12.0-marketing_crm_partner Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-marketing_crm_partner/ca/
Currently translated at 100.0% (6 of 6 strings) Translation: crm-12.0/crm-12.0-marketing_crm_partner Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-marketing_crm_partner/es/
Currently translated at 83.3% (5 of 6 strings) Translation: crm-12.0/crm-12.0-marketing_crm_partner Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-marketing_crm_partner/it/
Currently translated at 100.0% (6 of 6 strings) Translation: crm-12.0/crm-12.0-marketing_crm_partner Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-marketing_crm_partner/sl/
Currently translated at 100.0% (6 of 6 strings) Translation: crm-13.0/crm-13.0-marketing_crm_partner Translate-URL: https://translation.odoo-community.org/projects/crm-13-0/crm-13-0-marketing_crm_partner/es_AR/
Currently translated at 100.0% (6 of 6 strings) Translation: crm-14.0/crm-14.0-marketing_crm_partner Translate-URL: https://translation.odoo-community.org/projects/crm-14-0/crm-14-0-marketing_crm_partner/it/
Currently translated at 100.0% (9 of 9 strings) Translation: crm-15.0/crm-15.0-marketing_crm_partner Translate-URL: https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-marketing_crm_partner/es/
Currently translated at 100.0% (9 of 9 strings) Translation: crm-15.0/crm-15.0-marketing_crm_partner Translate-URL: https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-marketing_crm_partner/it/
Currently translated at 100.0% (9 of 9 strings) Translation: crm-16.0/crm-16.0-marketing_crm_partner Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-marketing_crm_partner/pt_BR/
Currently translated at 100.0% (9 of 9 strings) Translation: crm-16.0/crm-16.0-marketing_crm_partner Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-marketing_crm_partner/sv/
Currently translated at 100.0% (9 of 9 strings) Translation: crm-16.0/crm-16.0-marketing_crm_partner Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-marketing_crm_partner/es_AR/
@flotho Could you please make a review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code + Test LGTM
marketing_crm_partner/README.rst
Outdated
4. Go to **Extra Info > Marketing** and fill those fields: |lead view| | ||
5. **Save**. | ||
6. Click **Convert to Opportunity**. | ||
7. Choose the option **Customer > Create a new customer**. |choose | ||
customer| | ||
8. Click **Create Opportunity**. | ||
9. Click on the name of the newly linked partner. |new linked partner| | ||
10. Go to tab **Sales & Purchases**. | ||
11. There you have the new fulfilled fields in the marketing section. | ||
|partner marketing| | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The images don't load correctly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think as soon as the PR is merged, the images should be visible. The images point to the 17.0 repo, which should be correct in my opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, code review and tested in runboat
This PR has the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are new images in SVG that shouldn't be in that format, but PNG, and corresponding to enterprise snapshots. They should be in community version.
e70c794
to
9f1662e
Compare
@pedrobaeza Thanks for the hint. I made the requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes
/ocabot migration marketing_crm_partner
/ocabot merge nobump
What a great day to merge this nice PR. Let's do it! |
This PR has the |
Congratulations, your PR was merged at 7bd5f5c. Thanks a lot for contributing to OCA. ❤️ |
No description provided.