Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][FIX] currency_rate_update: Fix security vulnerability from CWE-61 #178

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

abhinavvaidya-tsd
Copy link
Contributor

No description provided.

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch.

@abhinavvaidya-tsd
Copy link
Contributor Author

hi @pedrobaeza I have created the PR to fix issue#177 but I do not know why it fails:

"ERROR: Could not find a version that satisfies the requirement pylint-plugin-utils==0.7 (from -r /home/travis/maintainer-quality-tools/travis/pylint_odoo_requirements.txt (line 1)) (from versions: 0.1, 0.1.1, 0.2, 0.2.1, 0.2.2, 0.2.3, 0.2.4, 0.2.6, 0.3, 0.4, 0.5, 0.6)
ERROR: No matching distribution found for pylint-plugin-utils==0.7 (from -r /home/travis/maintainer-quality-tools/travis/pylint_odoo_requirements.txt (line 1))
The command "travis_install_nightly" failed and exited with 1 during ."

@pedrobaeza
Copy link
Member

12.0 version is too old and CI is not adapted to "new times". One option is to use copier for updating the template for getting new CI definitions. Other is to make the PR to newer versions.

@abhinavvaidya-tsd
Copy link
Contributor Author

12.0 version is too old and CI is not adapted to "new times". One option is to use copier for updating the template for getting new CI definitions. Other is to make the PR to newer versions.

I tried adding in the .travis.yml but I see that I not the correct way to do it as it still fails :( I tried to look for copier and installed it too but did not know how to make it work.

@pedrobaeza
Copy link
Member

I have fixed the CI in #179. Please rebase and use proper commit message:

https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#71commit-message

This commit will fix the CWE-611 security vulnerability
@abhinavvaidya-tsd
Copy link
Contributor Author

@pedrobaeza thank you, I have fixed the PR with appropriate message and it is passing all the checks now.

@abhinavvaidya-tsd abhinavvaidya-tsd changed the title [MOD] Replace xml.sax.parse with method to parse using make_parser [FIX] Fix security vulnerability from CWE-61 Aug 28, 2023
@pedrobaeza pedrobaeza changed the title [FIX] Fix security vulnerability from CWE-61 [12.0][FIX] currency_rate_update: Fix security vulnerability from CWE-61 Aug 28, 2023
@pedrobaeza pedrobaeza added this to the 12.0 milestone Aug 28, 2023
@pedrobaeza
Copy link
Member

Module is not currency, but currency_rate_update, but let's not block this more time. Another thing is that it's not needed to bump manifest version. It's done on merge. I'm going to merge directly for changing commit message.

@pedrobaeza pedrobaeza merged commit a08e68f into OCA:12.0 Aug 28, 2023
@pedrobaeza
Copy link
Member

Please forward-port the change to upper versions.

@abhinavvaidya-tsd abhinavvaidya-tsd deleted the Issue#177 branch August 28, 2023 10:42
abhinavvaidya-tsd added a commit to abhinavvaidya-tsd/currency that referenced this pull request Aug 28, 2023
This commit will fix the CWE-611 security vulnerability
abhinavvaidya-tsd added a commit to abhinavvaidya-tsd/currency that referenced this pull request Aug 28, 2023
This commit will fix the CWE-611 security vulnerability
abhinavvaidya-tsd added a commit to abhinavvaidya-tsd/currency that referenced this pull request Aug 28, 2023
This commit will fix the CWE-611 security vulnerability
abhinavvaidya-tsd added a commit to abhinavvaidya-tsd/currency that referenced this pull request Aug 28, 2023
This commit will fix the CWE-611 security vulnerability
abhinavvaidya-tsd added a commit to abhinavvaidya-tsd/currency that referenced this pull request Aug 28, 2023
This commit will fix the CWE-611 security vulnerability
quoc-pn pushed a commit to quoc-pn/currency that referenced this pull request Nov 21, 2023
This commit will fix the CWE-611 security vulnerability
tupaq pushed a commit to GrupoYACCK/currency that referenced this pull request Oct 21, 2024
This commit will fix the CWE-611 security vulnerability
psugne pushed a commit to versada/currency that referenced this pull request Jan 20, 2025
This commit will fix the CWE-611 security vulnerability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants