Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG] base_delivery_carrier_label #251

Merged

Conversation

ps-tubtim
Copy link
Member

Standard Migration

@ps-tubtim ps-tubtim changed the title 13.0 mig base delivery carrier label [13.0][MIG] base_delivery_carrier_label Feb 6, 2020
@ps-tubtim ps-tubtim mentioned this pull request Feb 6, 2020
13 tasks
@ps-tubtim ps-tubtim force-pushed the 13.0-mig-base_delivery_carrier_label branch from e7d9e48 to 56b6e27 Compare February 6, 2020 08:43
@ps-tubtim ps-tubtim force-pushed the 13.0-mig-base_delivery_carrier_label branch 3 times, most recently from e175356 to 8d6f398 Compare March 20, 2020 08:06
@Saran440
Copy link
Member

@ps-tubtim Could you rebase commit from bot, please?

Copy link
Member

@Saran440 Saran440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review, No change

yvaucher and others added 20 commits October 21, 2020 15:50
… nesting, few typos

[ADD] access rights for the shipping.label model
[IMP] remove unused pdf_list variable and rename pdf variable to label as a label can have other printing format

[IMP] remove readonly on carrier_tracking_ref

[IMP] remove carrier_tracking_ref redefinition as already defined in delivery/stock.py

[ADD] stock users rights

[ADD] file type on shipping label

[ADD] pot file

[ADD] fr.po
…per pack (stock.tracking)

[IMP] set tracking_id as an optional key of dict returned by label generation and improve doc string

[IMP] rename generate_pack_labels in generate_shipping_labels as it can also generate a single label for a picking without pack notion

[IMP] set labels on stock.picking instead of stock.picking.out in order to let the creation of return labels to provide to the customer

[FIX] xml view and copy what is needed on stock.picking.out and stock.picking.in as it won't be inherited from stock.picking.out
[FIX] delivery.carrier has no access rights for stock users, hence remove it for delivery.carrier.option
…by raising a orm.except_orm

[FIX] trigger carrier_id on change when creating a stock.picking to set default options from sale.order

[IMP] change error message of unimplemented default to a more user friendly message
…te the label only for a selection of packs in a picking

the button call action_generate_carrier_label() without the 'context' keyword argument so the context ends in the tracking_ids argument. So the method now conforms to the cr, uid, ids, context signature and just forwards to a new generate_labels() method that should be used from within the code

do not overwrite the option_ids on create of stock.picking if already set in values, generalize the method to all types of picking (added in/out)

Set the default options of the delivery method when it is changed and the options are not set (typically a write from the code or a mass update)
[FIX] action name

[IMP] add descrption field to carrier option
[IMP] file_type field inheritance in shipping.label

[IMP] add field selection sort
[FIX] docstring

[FIX] _customize_sender_address return method

[IMP] add comment in _customize_sender_adress()

[FIX] method name to get sender address

[FIX] method comment
move modules in __unported__
[REF] port to v8 with old api

[MIG] to v8 base_deliv_label, deliv_carrier_deposit

[IMP] add parcel_tracking field

[IMP] add _get_packages_from_picking()

add carrier_id in tree view
yvaucher and others added 21 commits October 21, 2020 15:58
- Reactivate
- Move files in views and models
- Adapt XML views
- Update README.rst

Move settings menu in Inventory/Configuration

Remove test with Logistic units as it was removed from 9.0

Allow to give a filename to the created label if not defined use the attachment name

Fix weight calcul adding a field for total weight
This due to removed logistics units
If set this field will be used to define weight, otherwise we compute
weight even before quants have been created.

Fix stock picking view some labels were missing and the view was scrambled

Split files by model
Missing acl for stock user/manager
MIG 10.0 base_delivery_carrier_label
* Remove manifest.wizard model access rules.
* Add an attribute for the carrier tracking URI at the `stock.quant.package` level
Field carrier_type was originally type and was used to differentiate delivery carriers.
However odoo did implement delivery_type since v9 with this exact goal :
https://github.com/odoo/odoo/blob/11.0/addons/delivery/models/delivery_carrier.py#L22
This is also the field used in the implementation of enterprise modules for carriers.
Therefore we should use it instead of redefining a new one..
Currently translated at 100.0% (96 of 96 strings)

Translation: delivery-carrier-12.0/delivery-carrier-12.0-base_delivery_carrier_label
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-12-0/delivery-carrier-12-0-base_delivery_carrier_label/zh_CN/
@ps-tubtim ps-tubtim force-pushed the 13.0-mig-base_delivery_carrier_label branch from c8c50e7 to d7504e9 Compare October 21, 2020 09:00
@ps-tubtim
Copy link
Member Author

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-251-by-ps-tubtim-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at acf7801. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit d7d75a2 into OCA:13.0 Oct 21, 2020
victoralmau pushed a commit to Tecnativa/delivery-carrier that referenced this pull request Aug 4, 2021
Signed-off-by ps-tubtim
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.