[13.0] Add delivery_postlogistics_dangerous_goods #367

mmequignon · 2021-05-11T07:02:41Z

This modules overrides Postlogistics Shipping to declare dangerous goods
during postlogistics label generation.

Based on:

[13.0][IMP] delivery_postlogistics: add pack_weight parameter on _prepare_attributes #357

Supersedes:

[13.0] Add delivery_postlogistics_dangerous_goods #342

TDu · 2021-06-14T04:30:54Z

delivery_postlogistics_dangerous_goods/__manifest__.py

+    ],
+    "website": "https://github.com/OCA/delivery-carrier",
+    "installable": True,
+    "auto_install": False,


auto_install False is the default, so not really needed, here.
But does it not make sense to have it set to True ?

@mmequignon ping

Yeah, I don't know in what case we should enable auto-install or not

With auto_install set to True your module will be automatically installed when both its dependencies are installed. Which in my opinion makes sense in this case.

It makes sense to set it to True as this module doesn't break the base PostLogistics module.

simahawk

LG, one comment by @TDu needs answer

simahawk · 2021-06-14T06:35:51Z

delivery_postlogistics_dangerous_goods/__manifest__.py

+    ],
+    "website": "https://github.com/OCA/delivery-carrier",
+    "installable": True,
+    "auto_install": False,


@mmequignon ping

OCA-git-bot · 2021-06-14T06:38:51Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

dreispt · 2021-07-03T15:06:31Z

/ocabot merge nobump

OCA-git-bot · 2021-07-03T15:06:38Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-367-by-dreispt-bump-nobump, awaiting test results.

Signed-off-by dreispt

OCA-git-bot · 2021-07-03T17:47:45Z

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-367-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

grindtildeath · 2021-09-17T10:24:46Z

@mmequignon Can you please fix the CI ?

sebalix · 2021-10-11T14:00:31Z

/ocabot merge nobump

OCA-git-bot · 2021-10-11T14:01:00Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-367-by-sebalix-bump-nobump, awaiting test results.

Signed-off-by sebalix

OCA-git-bot · 2021-10-11T14:11:03Z

@sebalix your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-367-by-sebalix-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

sebalix · 2021-10-11T14:49:58Z

/ocabot merge nobump

OCA-git-bot · 2021-10-11T14:50:09Z

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-367-by-sebalix-bump-nobump, awaiting test results.

sebalix · 2021-10-14T14:35:27Z

Let's try again...
/ocabot merge nobump

OCA-git-bot · 2021-10-14T14:35:35Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-367-by-sebalix-bump-nobump, awaiting test results.

Signed-off-by sebalix

OCA-git-bot · 2021-10-14T14:54:15Z

@sebalix your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-367-by-sebalix-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

yvaucher · 2021-10-18T19:11:33Z

Is it intended to have that kind of output? It seems too verbose and not giving significant informations. The label binary gives a lot of noise.
It could reach some limit of the output or something like that.

Travis is still unhappy.

https://app.travis-ci.com/github/OCA/delivery-carrier/jobs/543251740#L1416

nilshamerlinck · 2021-10-28T07:26:18Z

Hi @mmequignon we faced this issue before and a workaround was to mute vcr logger for the case involving the big response; I tried it here, seems to work

dreispt · 2021-11-26T10:01:27Z

/ocabot merge nobump

OCA-git-bot · 2021-11-26T10:01:43Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-367-by-dreispt-bump-nobump, awaiting test results.

Signed-off-by dreispt

mmequignon · 2021-11-26T10:13:25Z

@dreispt thanks Daniel, but I think there's some action to do on my side before trying.
I have no time right now, but will fine to find some.
Sorry about that…

OCA-git-bot · 2021-11-26T11:28:26Z

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-367-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

github-actions · 2022-04-10T12:27:12Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

rousseldenis · 2023-02-06T08:10:40Z

@mmequignon No news on this ?

simahawk · 2023-02-20T16:27:13Z

@mmequignon ping

simahawk · 2023-02-24T14:13:32Z

we keep only v14 OCA/wms#334

mmequignon mentioned this pull request May 11, 2021

[13.0] Add delivery_postlogistics_dangerous_goods #342

Closed

sebalix approved these changes May 12, 2021

View reviewed changes

mmequignon force-pushed the 13.0-delivery-postlogistics-dangerous-goods_new branch from 0278821 to 0758137 Compare June 11, 2021 09:26

mmequignon mentioned this pull request Jun 11, 2021

[13.0][FIX] Do not send disallowed chars on postlogistics api #358

Merged

simahawk changed the title ~~13.0 delivery postlogistics dangerous goods new~~ [13.0] Add delivery_postlogistics_dangerous_goods Jun 11, 2021

mmequignon force-pushed the 13.0-delivery-postlogistics-dangerous-goods_new branch from 0758137 to ce84dd1 Compare June 11, 2021 12:46

TDu reviewed Jun 14, 2021

View reviewed changes

simahawk approved these changes Jun 14, 2021

View reviewed changes

OCA-git-bot added approved ready to merge labels Jun 14, 2021

OCA-git-bot added a commit that referenced this pull request Jul 3, 2021

Merge PR #367 into 13.0

365e825

Signed-off-by dreispt

OCA-git-bot added the bot is merging ⏳ label Jul 3, 2021

OCA-git-bot removed the bot is merging ⏳ label Jul 3, 2021

mmequignon force-pushed the 13.0-delivery-postlogistics-dangerous-goods_new branch from ce84dd1 to 1565b8a Compare July 5, 2021 08:44

mmequignon force-pushed the 13.0-delivery-postlogistics-dangerous-goods_new branch from 1565b8a to 6c61162 Compare September 15, 2021 07:50

dreispt added the needs fixing label Sep 23, 2021

sebalix force-pushed the 13.0-delivery-postlogistics-dangerous-goods_new branch from 6c61162 to 2e5d1f0 Compare October 11, 2021 13:35

OCA-git-bot added a commit that referenced this pull request Oct 11, 2021

Merge PR #367 into 13.0

984d45f

Signed-off-by sebalix

OCA-git-bot added the bot is merging ⏳ label Oct 11, 2021

OCA-git-bot removed the bot is merging ⏳ label Oct 11, 2021

OCA-git-bot removed the bot is merging ⏳ label Oct 14, 2021

mmequignon force-pushed the 13.0-delivery-postlogistics-dangerous-goods_new branch from dda5608 to 939ed46 Compare October 14, 2021 12:44

mmequignon added 2 commits October 14, 2021 16:11

Add delivery_postlogistics_dangerous_goods

5ef5a66

postlogistics fix tests an rebuild cassettes

7eabbca

mmequignon force-pushed the 13.0-delivery-postlogistics-dangerous-goods_new branch from 939ed46 to 7eabbca Compare October 14, 2021 14:11

OCA-git-bot added a commit that referenced this pull request Oct 14, 2021

Merge PR #367 into 13.0

c9712fc

Signed-off-by sebalix

OCA-git-bot added the bot is merging ⏳ label Oct 14, 2021

OCA-git-bot removed the bot is merging ⏳ label Oct 14, 2021

OCA-git-bot added a commit that referenced this pull request Nov 26, 2021

Merge PR #367 into 13.0

1140f25

Signed-off-by dreispt

OCA-git-bot added the bot is merging ⏳ label Nov 26, 2021

OCA-git-bot removed the bot is merging ⏳ label Nov 26, 2021

sebalix mentioned this pull request Dec 8, 2021

[14.0][MIG] delivery_postlogistics_dangerous_goods #441

Closed

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 10, 2022

simahawk added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Apr 12, 2022

simahawk mentioned this pull request Jul 28, 2022

[14.0][MIG] l10n_eu_product_adr OCA/community-data-files#109

Merged

simahawk closed this Feb 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[13.0] Add delivery_postlogistics_dangerous_goods #367

[13.0] Add delivery_postlogistics_dangerous_goods #367

mmequignon commented May 11, 2021 •

edited by sebalix

Loading

TDu Jun 14, 2021

simahawk Jun 14, 2021

mmequignon Jun 14, 2021

TDu Jun 14, 2021

sebalix Jun 24, 2021

simahawk left a comment

simahawk Jun 14, 2021

OCA-git-bot commented Jun 14, 2021

dreispt commented Jul 3, 2021

OCA-git-bot commented Jul 3, 2021

OCA-git-bot commented Jul 3, 2021

grindtildeath commented Sep 17, 2021

sebalix commented Oct 11, 2021

OCA-git-bot commented Oct 11, 2021

OCA-git-bot commented Oct 11, 2021

sebalix commented Oct 11, 2021

OCA-git-bot commented Oct 11, 2021

sebalix commented Oct 14, 2021

OCA-git-bot commented Oct 14, 2021

OCA-git-bot commented Oct 14, 2021

yvaucher commented Oct 18, 2021

nilshamerlinck commented Oct 28, 2021

dreispt commented Nov 26, 2021

OCA-git-bot commented Nov 26, 2021

mmequignon commented Nov 26, 2021

OCA-git-bot commented Nov 26, 2021

github-actions bot commented Apr 10, 2022

rousseldenis commented Feb 6, 2023

simahawk commented Feb 20, 2023

simahawk commented Feb 24, 2023

[13.0] Add delivery_postlogistics_dangerous_goods #367

[13.0] Add delivery_postlogistics_dangerous_goods #367

Conversation

mmequignon commented May 11, 2021 • edited by sebalix Loading

TDu Jun 14, 2021

Choose a reason for hiding this comment

simahawk Jun 14, 2021

Choose a reason for hiding this comment

mmequignon Jun 14, 2021

Choose a reason for hiding this comment

TDu Jun 14, 2021

Choose a reason for hiding this comment

sebalix Jun 24, 2021

Choose a reason for hiding this comment

simahawk left a comment

Choose a reason for hiding this comment

simahawk Jun 14, 2021

Choose a reason for hiding this comment

OCA-git-bot commented Jun 14, 2021

dreispt commented Jul 3, 2021

OCA-git-bot commented Jul 3, 2021

OCA-git-bot commented Jul 3, 2021

grindtildeath commented Sep 17, 2021

sebalix commented Oct 11, 2021

OCA-git-bot commented Oct 11, 2021

OCA-git-bot commented Oct 11, 2021

sebalix commented Oct 11, 2021

OCA-git-bot commented Oct 11, 2021

sebalix commented Oct 14, 2021

OCA-git-bot commented Oct 14, 2021

OCA-git-bot commented Oct 14, 2021

yvaucher commented Oct 18, 2021

nilshamerlinck commented Oct 28, 2021

dreispt commented Nov 26, 2021

OCA-git-bot commented Nov 26, 2021

mmequignon commented Nov 26, 2021

OCA-git-bot commented Nov 26, 2021

github-actions bot commented Apr 10, 2022

rousseldenis commented Feb 6, 2023

simahawk commented Feb 20, 2023

simahawk commented Feb 24, 2023

mmequignon commented May 11, 2021 •

edited by sebalix

Loading