Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] delivery_carrier_info: Migration to 15.0 #475

Merged
merged 12 commits into from
Jul 18, 2022
Merged

[MIG] delivery_carrier_info: Migration to 15.0 #475

merged 12 commits into from
Jul 18, 2022

Conversation

fshah-initos
Copy link
Contributor

No description provided.

@fshah-initos fshah-initos force-pushed the 15.0-mig-delivery_carrier_info branch 2 times, most recently from 7a5f99e to 7ac3668 Compare April 20, 2022 10:49
@fshah-initos fshah-initos mentioned this pull request Apr 20, 2022
Merged
@florian-dacosta
Copy link
Contributor

Hello @fshah-initos
Thanks for the contribution.
There is a problem here, the commit history is lost and it is important to preserve it.
You can follow the method described here : https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0
(This step in particular git format-patch --keep-subject --stdout origin/15.0..origin/14.0 -- $MODULE | git am -3 --keep)

@fshah-initos fshah-initos force-pushed the 15.0-mig-delivery_carrier_info branch from 7ac3668 to 8cd81b1 Compare April 20, 2022 12:28
@rousseldenis
Copy link
Contributor

/ocabot migration delivery_carrier_info

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Apr 20, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 20, 2022
Open
32 tasks
@rousseldenis
Copy link
Contributor

@fshah-initos The module exists in 14.0 branch, so, why not basing your work on that (instead of 12.0) ?

@fshah-initos fshah-initos force-pushed the 15.0-mig-delivery_carrier_info branch from 8cd81b1 to f8fd8cf Compare April 27, 2022 09:33
sebastienbeau and others added 12 commits April 27, 2022 16:14
@fshah-initos fshah-initos force-pushed the 15.0-mig-delivery_carrier_info branch from f8fd8cf to fa897b9 Compare April 27, 2022 10:48
dsolanki-initos
dsolanki-initos approved these changes May 27, 2022
View reviewed changes
Copy link

@dsolanki-initos dsolanki-initos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and functional tests.
Looks good to me.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@ikapasi-initos
Copy link

It would be nice maintainer approve this pull.

@rousseldenis
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-475-by-rousseldenis-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8fd33a4 into OCA:15.0 Jul 18, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 96434e2. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-dacosta florian-dacosta florian-dacosta approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

@dsolanki-initos dsolanki-initos dsolanki-initos approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
10 participants
@fshah-initos @florian-dacosta @rousseldenis @OCA-git-bot @ikapasi-initos @dsolanki-initos @sebastienbeau @oca-travis @sbidoul @Yvesldff