Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15.0 mig delivery carrier category #602

Closed

Conversation

pere-aquarian
Copy link

No description provided.

@pere-aquarian pere-aquarian mentioned this pull request Jan 19, 2023
32 tasks
@rousseldenis
Copy link
Contributor

/ocabot migration delivery_carrier_category

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pere-aquarian Thanks for this.

Could you attend comment and as module exists in v14, migrate from that one?

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change test class to TransactionCase and squash your commits to keep migration one ? Thanks

delivery_carrier_category/tests/test_carrier_category.py Outdated Show resolved Hide resolved
@pere-aquarian
Copy link
Author

Thank you for the patience, @rousseldenis . Just a rookie on that and I am starting from the easiest modules to understand the whole process. Think I am done. Commits squashed and only one left with the migration one.

@rousseldenis
Copy link
Contributor

Thank you for the patience, @rousseldenis . Just a rookie on that and I am starting from the easiest modules to understand the whole process. Think I am done. Commits squashed and only one left with the migration one.

@pere-aquarian No problem, always a pleasure to welcome new people contributing ! I'll try to look at it today

@pere-aquarian
Copy link
Author

@jcbr87 Could you please take a look at it?
Thank you!

@github-actions
Copy link

github-actions bot commented Jul 2, 2023

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 2, 2023
@pere-aquarian
Copy link
Author

Hi, @rousseldenis !

Is there something more I have to do? Sorry my ignorance.

Thank you!

@rousseldenis
Copy link
Contributor

@pere-aquarian It seems your commit history is quite a mess as there is another module in it.

Did you follow the migration guide I've provided here above (especially the Full process part) ?

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 23, 2023
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 26, 2023
@github-actions github-actions bot closed this Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants