-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][FIX] base_delivery_carrier_files: Reset cursor back for StringIO() #612
[14.0][FIX] base_delivery_carrier_files: Reset cursor back for StringIO() #612
Conversation
@thomaspaulb This fixes the binary data when you have multiple |
To be more complete, for other reviewers to understand: Problem was: The lines in the generated carrier file had a bunch of leading ASCII 0x00 characters, the amount of which was increasing for each subsequent line. This caused the file to become seen as binary instead of text, plus have a lot of useless content. |
@ntsirintanis @NL66278 Mind reviewing also |
@Kiplangatdan Maybe a test that highlight this change ? |
This PR has the |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
/ocabot merge patch |
Sorry @thomaspaulb you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
@OCA/logistics-maintainers Could this be merged? |
/ocabot merge patch |
Hey, thanks for contributing! Proceeding to merge this for you. |
@jbaudoux your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-612-by-jbaudoux-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
/ocabot merge patch |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 8d151b1. Thanks a lot for contributing to OCA. ❤️ |
No description provided.