[14.0][IMP] delivery_schenker : submit booking #723
Conversation
vnikolayev1
commented
Oct 25, 2023
vnikolayev1
commented
- Added field for schenker delivery carrier, where user can pick if they want to submit booking on schenker site. In case where it is turned off - user has to submit booking manually.
vnikolayev1
force-pushed
the
14.0
branch
2 times, most recently
from
9bcff44 to
f698a39
Compare
| # Defines if booking shall be submitted. If false, | ||
| # the booking can be edited | ||
| # in the frontend and MUST be submitted manually. | ||
| "submitBooking": picking.carrier_id.is_schenker_submit_booking, |
There was a problem hiding this comment.
| "submitBooking": picking.carrier_id.is_schenker_submit_booking, | |
| "submitBooking": self.is_schenker_submit_booking, |
| is_schenker_submit_booking = fields.Boolean( | ||
| string="Submit Booking", | ||
| default=True, | ||
| help="Submit Booking On Schenker site." | ||
| "\nIf set, submits booking on site automatically." | ||
| "\nIf not set, user has to submit booking manually.", | ||
| ) |
There was a problem hiding this comment.
Could you please change the name of the field to schenker_submit_booking
| is_schenker_submit_booking = fields.Boolean( | |
| string="Submit Booking", | |
| default=True, | |
| help="Submit Booking On Schenker site." | |
| "\nIf set, submits booking on site automatically." | |
| "\nIf not set, user has to submit booking manually.", | |
| ) | |
| schenker_submit_booking = fields.Boolean( | |
| string="Submit Booking", | |
| default=True, | |
| help="Submit Booking On Schenker site." | |
| "\nIf set, submits booking on site automatically." | |
| "\nIf not set, user has to submit booking manually.", | |
| ) |
delivery_schenker/__manifest__.py
Outdated
| @@ -4,7 +4,7 @@ | |||
| { | |||
| "name": "Delivery Schenker", | |||
| "summary": "Delivery Carrier implementation for DB Schenker API", | |||
| "version": "14.0.1.2.0", | |||
| "version": "14.0.1.2.1", | |||
There was a problem hiding this comment.
Please remove this change. This should be automatically done by the merge bot.
delivery_schenker/tests/common.py
Outdated
| cls.picking.write( | ||
| { | ||
| "shipping_weight": 1, | ||
| "number_of_packages": 1, | ||
| } | ||
| ) |
There was a problem hiding this comment.
What is the purpose of this change?
vnikolayev1
force-pushed
the
14.0
branch
2 times, most recently
from
5ae8731 to
87b80e8
Compare
jbaudoux
changed the title
|
@vnikolayev1 Can you rebase and repush as pre-commit failed |
|
@jbaudoux sorry for delay, should be good now |
Please rebase and not merge. To get rid of the second commit. |
- Added field for schenker delivery carrier, where user can pick if they want to submit booking on schenker site. In case where it is turned off - user has to submit booking manually.
|
This PR has the |
|
/ocabot merge minor |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at cd116d1. Thanks a lot for contributing to OCA. ❤️ |
