Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dms): add file content search to community version [Silvertouch … #366

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

dakshesh-sttl
Copy link

…Technologies]

Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the PR is wrong, remember the guidelines, it should be: [16.0][IMP] dms: Add indexed content to files (or similar)

Considering base does with ir.attachment (https://github.com/odoo/odoo/blob/14.0/odoo/addons/base/models/ir_attachment.py#L355) and the attachment_indexation module I think the following should be done (if possible):

  • The index_content field should be a compute store and set the value in a “similar” way as it is done in base.
  • Create a module called dms_indexation that depends on attachment_indexation and dms and “extend” the dms method to contemplate more formats.

What do you think @pedrobaeza ?

I think that creating PRs for all branches is not a good technique, because if you have to change something you will have to change it in all of them, the right thing to do is to create one and when it is merged take it to higher versions (one by one).

@pedrobaeza
Copy link
Member

Yes, please put this on a separate module for being optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants