Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.0][IMP] product_template_multi_link: Several improvements #452

Merged
merged 6 commits into from
May 9, 2021
Merged

[10.0][IMP] product_template_multi_link: Several improvements #452

merged 6 commits into from
May 9, 2021

Conversation

rousseldenis
Copy link

acsonefho and others added 2 commits October 22, 2020 19:10
@acsonefho @rousseldenis
[10.0][ADD] product_tempalte_multi_link: add possibility to link prod…
266ae01 
…ucts in one shot by selecting them into Tree view and picking the link type (by a wizard). You can also remove every link of a product. + Update Readme + add unit tests
@lmignon @rousseldenis
[IMP] product_template_multi_link: Makes links bi-directional
ae27763 
fixes OCA#307
@rousseldenis
Copy link
Author

@Cedric-Pigeon @lmignon @acsonefho This is a merge PR of several improvements in order to have no conflicts.

@rousseldenis rousseldenis force-pushed the 10.0-imp-link--wizard_and_optimizations-dro branch from 369577d to 73ce087 Compare October 23, 2020 07:42
@rousseldenis rousseldenis mentioned this pull request Oct 23, 2020
Closed
1 task
@rousseldenis rousseldenis force-pushed the 10.0-imp-link--wizard_and_optimizations-dro branch from 73ce087 to 4d4fc17 Compare October 23, 2020 13:36
@rousseldenis rousseldenis force-pushed the 10.0-imp-link--wizard_and_optimizations-dro branch from 4d4fc17 to 31623bb Compare October 27, 2020 14:17
@lmignon
Copy link

lmignon commented Oct 29, 2020

@rousseldenis We have 2 entries for le links into the menu... one for product.template and one for product.product. Unfortunately, there is nothing to distinguish which one is for which model.
image

@rousseldenis
Copy link
Author

@rousseldenis We have 2 entries for le links into the menu... one for product.template and one for product.product. Unfortunately, there is nothing to distinguish which one is for which model.
image

Ok, I'll check

lmignon
lmignon approved these changes Oct 29, 2020
View reviewed changes
Copy link

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little comment otherwise LGTM (Code review + Functional tests)

@dreispt
Copy link
Member

dreispt commented May 8, 2021

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 10.0-ocabot-merge-pr-452-by-dreispt-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3b0e234 into OCA:10.0 May 9, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ea7e686. Thanks a lot for contributing to OCA. ❤️

@lmignon lmignon deleted the 10.0-imp-link--wizard_and_optimizations-dro branch May 10, 2021 05:28
@acsonefho acsonefho mentioned this pull request Jul 8, 2021
Closed
@acsonefho acsonefho mentioned this pull request Nov 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cedric-Pigeon Cedric-Pigeon Cedric-Pigeon approved these changes

@lmignon lmignon lmignon approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rousseldenis @lmignon @dreispt @OCA-git-bot @Cedric-Pigeon @acsonefho