[17.0][MIG] website_sale_cart_expire: Migration #923
+1,362
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Module that allows to automatically cancel carts without activity after a configurable time.
In a typical website flow, quotations are moved to sent state when a payment by Wire transfer is chosen. In this scenario, the quotation shouldn't be automatically cancelled. It's up to the salesman to determine when a sent quotation is expired, as technically speaking this isn't just a cart anymore.
[Fix] Use new payment.payment_provider_demo for test cases [Fix] Change acquirer_id to provider_id for test cases
Currently translated at 100.0% (14 of 14 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_cart_expire Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_cart_expire/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-16.0/e-commerce-16.0-website_sale_cart_expire Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_cart_expire/
Before this commit, there are an issue the method raise an error if transaction_ids.last_state_change was false. It's possible for last_state_change to be false as a result of migrating data from a past Odoo DB version.
Currently translated at 100.0% (14 of 14 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_cart_expire Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_cart_expire/it/
Mantux11
force-pushed
the
17.0-27851-website_sale_cart_expire
branch
from
a46663a
to
dd27f68
Compare
DorianMAG
reviewed
Jun 21, 2024
There was a problem hiding this comment.
Hi @Mantux11
I m not sure to understand why, we find a binary file (.deb) in the PR
https://github.com/OCA/e-commerce/pull/923/files#diff-de4e69c46f94e742c70468b9e0f08ebc21bf93aa8a5b98463faf63effa1e7c8a
Same for the migration v15 folder?
Functional test it's ok
|
@DorianMAG Hey. I don't know why there is a random file. As I see, Personally, i don't know what this file should do and why it was added in the first place. |
|
It must be removed in the same commit that added it. |
Mantux11
force-pushed
the
17.0-27851-website_sale_cart_expire
branch
from
dd27f68
to
42bb648
Compare
|
@pedrobaeza file removed. |
|
Thanks. /ocabot migration website_sale_cart_expire |
gaikaz
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module
website_sale_cart_expiremigration to17.0.