[17.0][MIG] website_sale_suggest_create_account #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example of module which requires such refactoring: https://github.com/it-projects-llc/website-addons/tree/10.0/website_sale_checkout_store [FIX] condition to show normal checkout button was wrong in website_sale_suggest_create_account I was equal to (user_authenticated or not signup_allowed and can_checkout) while it has to be (user_authenticated or not signup_allowed) and can_checkout
Always show 'Process Checkout', not highlighted if user not logged in Suggest to login or signup, according to 'invitation_scope', avoiding too many buttons in cart page
Currently translated at 100.0% (4 of 4 strings) Translation: e-commerce-12.0/e-commerce-12.0-website_sale_suggest_create_account Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_suggest_create_account/es/
Ensure that 'vat' is not empty for compatibility with website_sale_vat_required module
…with `Environment.manage()`
- Create setUpClass method - Include context keys for avoiding mail operations overhead.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-16.0/e-commerce-16.0-website_sale_suggest_create_account Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_suggest_create_account/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-16.0/e-commerce-16.0-website_sale_suggest_create_account Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_suggest_create_account/
Currently translated at 100.0% (5 of 5 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_suggest_create_account Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_suggest_create_account/es/
…solve conflict between 'website_sale_suggest_create_account' and 'website_sale_checkout_skip_payment' This commit addresses a conflict between the 'website_sale_suggest_create_account' and 'website_sale_checkout_skip_payment' modules. When 'website_sale_suggest_create_account' is installed, it modifies a section of the view by removing a class. Subsequently, upon installing the 'website_sale_checkout_skip_payment' module, it expects to find this class, resulting in an error due to the previous deletion. By adjusting the priority of the view, this commit ensures that the necessary class is retained during positioning, resolving the conflict.
Currently translated at 100.0% (5 of 5 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_suggest_create_account Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_suggest_create_account/it/
cem-adhoc
force-pushed
the
17.0-mig-website_sale_suggest_create_account
branch
from
a90da91
to
c786080
Compare
pedrobaeza
changed the title
|
/ocabot migration website_sale_suggest_create_account |
chienandalu
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Code and functional review 👍
please review @pilarvargas-tecnativa
| @@ -1,105 +1,63 @@ | |||
| <?xml version="1.0" encoding="utf-8" ?> | |||
| <odoo> | |||
| <template | |||
| id="cart" | |||
| inherit_id="website_sale.cart" | |||
| id="navigation_buttons" | |||
There was a problem hiding this comment.
You should make a migration script for this change in the template id. It is not advisable to leave duplicate old views.
There was a problem hiding this comment.
@pilarvargas-tecnativa Do you have any example of a migration script for this? It would be helpful to see how these cases are handled specifically. Thank you.
There was a problem hiding this comment.
For example:
But you must create the directory (migrations) and the migration files (pre or post) in the module itself.
There was a problem hiding this comment.
@pilarvargas-tecnativa done. can you review it?
cem-adhoc
force-pushed
the
17.0-mig-website_sale_suggest_create_account
branch
from
c786080
to
5fb276a
Compare
cem-adhoc
force-pushed
the
17.0-mig-website_sale_suggest_create_account
branch
from
5fb276a
to
731ebc5
Compare
pilarvargas-tecnativa
approved these changes
Jul 26, 2024
|
This PR has the |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 6227cfe. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.