[17.0] [MIG] website_sale_require_login #973
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example of module which requires such refactoring: https://github.com/it-projects-llc/website-addons/tree/10.0/website_sale_checkout_store [FIX] condition to show normal checkout button was wrong in website_sale_suggest_create_account I was equal to (user_authenticated or not signup_allowed and can_checkout) while it has to be (user_authenticated or not signup_allowed) and can_checkout
This test was expecting sign up to be disabled because `auth_signup` is not in its module graph, but since that addon is autoinstallable, it could be installed without our knowledge. Just make sure signup is disabled before running the public user test, to make it unitary. Also, moved to at-install mode, since the post-install one adds no value.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-14.0/e-commerce-14.0-website_sale_require_login Translate-URL: https://translation.odoo-community.org/projects/e-commerce-14-0/e-commerce-14-0-website_sale_require_login/
azimkhankuat
force-pushed
the
17.0-mig-website_sale_require_login
branch
2 times, most recently
from
8174945 to
1722c67
Compare
azimkhankuat
force-pushed
the
17.0-mig-website_sale_require_login
branch
4 times, most recently
from
8176835 to
b4f8bb9
Compare
azimkhankuat
force-pushed
the
17.0-mig-website_sale_require_login
branch
from
b4f8bb9 to
d8fa1a1
Compare
|
Suddenly found out, that it is already built-in function in Odoo. |
pedrobaeza
requested changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[17.0] [MIG] website_sale_require_login