[18.0] [MIG] website_sale_hide_price: Migration to 18.0 #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (4 of 4 strings) Translation: e-commerce-11.0/e-commerce-11.0-website_sale_hide_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-11-0/e-commerce-11-0-website_sale_hide_price/fa/
Currently translated at 75.0% (3 of 4 strings) Translation: e-commerce-11.0/e-commerce-11.0-website_sale_hide_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-11-0/e-commerce-11-0-website_sale_hide_price/de/
…event show prices in cart (OCA#244) * Add to cart hidden if not website_show_price * Hide quantity selector * bump version and added contributor
add original validation of the view
Currently translated at 50.0% (2 of 4 strings) Translation: e-commerce-11.0/e-commerce-11.0-website_sale_hide_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-11-0/e-commerce-11-0-website_sale_hide_price/it/
Currently translated at 100.0% (4 of 4 strings) Translation: e-commerce-12.0/e-commerce-12.0-website_sale_hide_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_hide_price/de/
Currently translated at 100.0% (4 of 4 strings) Translation: e-commerce-12.0/e-commerce-12.0-website_sale_hide_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_hide_price/sl/
Currently translated at 100.0% (4 of 4 strings) Translation: e-commerce-13.0/e-commerce-13.0-website_sale_hide_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_hide_price/ca/
Currently translated at 100.0% (4 of 4 strings) Translation: e-commerce-13.0/e-commerce-13.0-website_sale_hide_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_hide_price/es/
Currently translated at 100.0% (4 of 4 strings) Translation: e-commerce-14.0/e-commerce-14.0-website_sale_hide_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-14-0/e-commerce-14-0-website_sale_hide_price/es_AR/
No we can hide the price only for the products we want to. TT36129
Adapt to the new base module feature
Currently translated at 100.0% (4 of 4 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_hide_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_hide_price/it/
Currently translated at 100.0% (4 of 4 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_hide_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_hide_price/it/
Currently translated at 100.0% (11 of 11 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_hide_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_hide_price/es_AR/
Currently translated at 100.0% (11 of 11 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_hide_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_hide_price/pt/
When editing the website, a problem was encountered when inserting and editing the dynamic product snippet. When changing the filter to "product accessories" or "recently sold products", an error occurred accessing the "website_hide_price" key if it didn't exist. The solution involves modifying the access to the "website_hide_price" key, thus avoiding the mentioned error. With this correction, the proper functioning of dynamic product snippets is guaranteed. TT43493
Hide add to cart button and prices from dynamic product snippet templates if not website_show_price When inheriting templates from the snippet, they were duplicated in the web editor selector. To avoid this, they have been defined in "data" like odoo does and the id's of the child templates have been modified. TT43493
When the "add_to_cart" option was activated, the add to cart button was not hidden and the product could be added and this functionality has been corrected. The same applies to the "Buy Now Button" option. TT41911
Currently translated at 100.0% (11 of 11 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_hide_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_hide_price/de/
Currently translated at 100.0% (11 of 11 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_hide_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_hide_price/es/
[FIX] website_sale_hide_price update t-cache for updating template
Currently translated at 100.0% (11 of 11 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_hide_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_hide_price/ja/
Currently translated at 100.0% (14 of 14 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_hide_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_hide_price/es/
Currently translated at 100.0% (14 of 14 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_hide_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_hide_price/es_AR/
Currently translated at 100.0% (13 of 13 strings) Translation: e-commerce-17.0/e-commerce-17.0-website_sale_hide_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-17-0/e-commerce-17-0-website_sale_hide_price/it/
Currently translated at 100.0% (13 of 13 strings) Translation: e-commerce-17.0/e-commerce-17.0-website_sale_hide_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-17-0/e-commerce-17-0-website_sale_hide_price/it/
Fix caching of the website_sale.products view override. Before this commit, this module added a view that added two price website related cache keys to the products grid wrapper. In Odoo 17.0, caching was removed for this element. In combination with this module, this resulted in re-rendering this portion of the view, only depending on the cache keys added by this module. Because of it, searched products didn't update when changing any of the search parameters. This commit fixes it, by removing that override, and leaving the elements cache disabled.
Currently translated at 100.0% (13 of 13 strings) Translation: e-commerce-17.0/e-commerce-17.0-website_sale_hide_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-17-0/e-commerce-17-0-website_sale_hide_price/sv/
Replaced view inheritance with Python logic in _website_show_quick_add to fix an issue where the "Add to Cart" button visibility was incorrectly overridden by this module. This update restores the expected behavior by ensuring the inherited logic determines button visibility.
peluko00
reviewed
Dec 10, 2024
| website_hide_price = fields.Boolean( | ||
| string="Hide prices on website", | ||
| related="website_id.website_hide_price", | ||
| readonly=False, |
| ) | ||
| website_hide_price_default_message = fields.Char( | ||
| related="website_id.website_hide_price_default_message", | ||
| readonly=False, |
There was a problem hiding this comment.
Tested in runboat works good but take a look of the comments @Borruso
Borruso
force-pushed
the
18.0-mig-website_sale_hide_price
branch
from
bc4a9cf to
c0a2382
Compare
Borruso
force-pushed
the
18.0-mig-website_sale_hide_price
branch
from
c0a2382 to
70ddfa0
Compare
|
@peluko00 thanks for review! |
peluko00
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration from 17.0 to 18.0
Issue: #974