Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] product_variant_multi_link: Migration to 18.0 #992

Open
wants to merge 23 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][MIG] product_variant_multi_link: Migration to 18.0 #992

wants to merge 23 commits into from

Conversation

thienvh332
Copy link

@thienvh332 thienvh332 commented Dec 6, 2024 •
edited
Loading

simahawk and others added 22 commits November 29, 2024 12:27
@simahawk @thienvh332
Add product_variant_multi_link
4b23ae9
@oca-travis @thienvh332
[UPD] Update product_variant_multi_link.pot
c96cf3a
@OCA-git-bot @thienvh332
[UPD] README.rst
b3599f8
@OCA-git-bot @thienvh332
[ADD] icon.png
17f056a
@bosd @thienvh332
Added translation using Weblate (Dutch)
f351b8b
@bosd @thienvh332
Translated using Weblate (Dutch)
45b889d 
Currently translated at 100.0% (7 of 7 strings)

Translation: e-commerce-13.0/e-commerce-13.0-product_variant_multi_link
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-product_variant_multi_link/nl/
@chafique-delli @thienvh332
[IMP] product_variant_multi_link: black, isort, prettier
5f4ffcc
@chafique-delli @thienvh332
[MIG] product_variant_multi_link: Migration to 14.0
9504b99
@oca-travis @thienvh332
[UPD] Update product_variant_multi_link.pot
9f57920
@OCA-git-bot @thienvh332
[UPD] README.rst
28bfdc7
@ibuioli @thienvh332
Added translation using Weblate (Spanish (Argentina))
f7c5884
@ibuioli @thienvh332
Translated using Weblate (Spanish (Argentina))
91ca6db 
Currently translated at 100.0% (10 of 10 strings)

Translation: e-commerce-14.0/e-commerce-14.0-product_variant_multi_link
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-14-0/e-commerce-14-0-product_variant_multi_link/es_AR/
@ajaniszewska-dev @thienvh332
[IMP] Add product links smartbutton
79d499d
@oca-travis @thienvh332
[UPD] Update product_variant_multi_link.pot
8bebba7
@OCA-git-bot @thienvh332
product_variant_multi_link 14.0.1.1.0
ed7b727
@oca-transbot @thienvh332
Update translation files
4ed61bf 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: e-commerce-14.0/e-commerce-14.0-product_variant_multi_link
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-14-0/e-commerce-14-0-product_variant_multi_link/
@ibuioli @thienvh332
Translated using Weblate (Spanish (Argentina))
4ac3de9 
Currently translated at 100.0% (13 of 13 strings)

Translation: e-commerce-14.0/e-commerce-14.0-product_variant_multi_link
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-14-0/e-commerce-14-0-product_variant_multi_link/es_AR/
@OCA-git-bot @thienvh332
[UPD] README.rst
f9e88cf
@Ivorra78 @thienvh332
Added translation using Weblate (Spanish)
d8f7ef3
@Ivorra78 @thienvh332
Translated using Weblate (Spanish)
e9575bc 
Currently translated at 15.3% (2 of 13 strings)

Translation: e-commerce-14.0/e-commerce-14.0-product_variant_multi_link
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-14-0/e-commerce-14-0-product_variant_multi_link/es/
@Ivorra78 @thienvh332
Translated using Weblate (Spanish)
6d5cd0c 
Currently translated at 100.0% (13 of 13 strings)

Translation: e-commerce-14.0/e-commerce-14.0-product_variant_multi_link
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-14-0/e-commerce-14-0-product_variant_multi_link/es/
@thienvh332
[IMP] product_variant_multi_link: pre-commit auto fixes
504d5c7
@thienvh332 thienvh332 marked this pull request as ready for review December 6, 2024 05:08
sebalix
sebalix reviewed Dec 11, 2024
View reviewed changes
product_variant_multi_link/tests/test_product_template_link.py Outdated


class TestProductVariantLink(SavepointCase):
class TestProductVariantLink(TransactionCase):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can inherit from BaseCommon class and remove the cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True)) line in setUpClass method

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated it. Thanks 🙏

@thienvh332 thienvh332 force-pushed the 18.0-mig-product_variant_multi_link branch from 3861b06 to 91936ef Compare December 12, 2024 03:02
sebalix
sebalix approved these changes Dec 23, 2024
View reviewed changes
Copy link

@sebalix sebalix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, DON'T MERGE commit can be removed, dependency is merged

@thienvh332 thienvh332 force-pushed the 18.0-mig-product_variant_multi_link branch from 91936ef to 6ef4696 Compare December 23, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebalix sebalix sebalix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.