[14.0][BPRT] edi_sale_oca: Backport from v16.0 #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines w/ no qty must not be excluded a priori
…env_ctx The configurations here are values for the wizard and whatever we need
mmequignon
reviewed
Oct 31, 2024
|
|
||
| @classmethod | ||
| def _setup_order(cls, **kw): | ||
| cls.product_a = cls.env.ref("product.product_product_4") |
There was a problem hiding this comment.
Please, create products instead of using odoo demo ones, we want to have control about their configuration.
It also help with understanding during reviews, no one can guess what's their sale_delay for instance, without having to check odoo demo data.
There was a problem hiding this comment.
We can do this in a 2nd iteration
simahawk
approved these changes
Nov 14, 2024
|
|
||
| @classmethod | ||
| def _setup_order(cls, **kw): | ||
| cls.product_a = cls.env.ref("product.product_product_4") |
There was a problem hiding this comment.
We can do this in a 2nd iteration
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 222e606. Thanks a lot for contributing to OCA. ❤️ |
This was referenced Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Context:
Changes: