Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0][training_track] Adapt event tracks to trainings #15

Closed
wants to merge 53 commits into from
Closed

[8.0][training_track] Adapt event tracks to trainings #15

wants to merge 53 commits into from

Conversation

yajo
Copy link
Member

@yajo yajo commented Nov 6, 2015

Relaunch second split module from #13. Merged with #14 to make it work. Target: OCA/l10n-spain#174. CC @dreispt @pedrobaeza.

Training Tracks

This module combines the power of modules training and
website_event_track.

Event tracks can get a training duration type, so it lets the user know if
the training group has fulfilled all the expected hours for it.

Jairo Llopis added 30 commits November 6, 2015 13:20
They did not have in account that were working in onchange context.
Rename self.action_type to self.action_type_good, to allow having a bad
type in the future.

Also use env.do_in_onchange() for better onchange testing.
It happens when the user edits the training action, selects a type that
does not have the duration types that the action had before, and then
selects again another type that does have those duration types without
saving.
Sort alphabetically data import.
Split long imports.
========

This module was written to extend the functionality of events to support
trainings and allow you to manage training actions, training groups,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

training is no plural (check PR#16)

@dreispt
Copy link
Member

dreispt commented Nov 7, 2015

@yajo One module per PR please. Isn't training already in #14? This PR will have conflicts when that is merged. Just signal in the description that it depends on #14.

@yajo yajo changed the title Training track [8.0][training_track] Training track Nov 11, 2015
@yajo yajo changed the title [8.0][training_track] Training track [8.0][training_track] Adapt event tracks to trainings Nov 11, 2015
@yajo
Copy link
Member Author

yajo commented Nov 20, 2015

This seems to confuse reviewers, and #14 is being totally refactored so this will have to change too. Closing until #14 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants