-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.0][training_track] Adapt event tracks to trainings #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They did not have in account that were working in onchange context.
Rename self.action_type to self.action_type_good, to allow having a bad type in the future. Also use env.do_in_onchange() for better onchange testing.
It happens when the user edits the training action, selects a type that does not have the duration types that the action had before, and then selects again another type that does have those duration types without saving.
Thanks to odoo/odoo#9105 (comment).
Sort alphabetically data import. Split long imports.
When user is in Training menu, it enables training_mode flag in the event, and this makes the field training_action_id to be required.
It was lacking the developer name.
It was lacking the developer name.
======== | ||
|
||
This module was written to extend the functionality of events to support | ||
trainings and allow you to manage training actions, training groups, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
training is no plural (check PR#16)
yajo
changed the title
[8.0][training_track] Training track
[8.0][training_track] Adapt event tracks to trainings
Nov 11, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relaunch second split module from #13. Merged with #14 to make it work. Target: OCA/l10n-spain#174. CC @dreispt @pedrobaeza.
Training Tracks
This module combines the power of modules
training
andwebsite_event_track
.Event tracks can get a training duration type, so it lets the user know if
the training group has fulfilled all the expected hours for it.