Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0][event_product] New module to combine events and products #21

Merged
merged 16 commits into from Jan 20, 2016
Merged

[8.0][event_product] New module to combine events and products #21

merged 16 commits into from Jan 20, 2016

Conversation

yajo
Copy link
Member

@yajo yajo commented Nov 27, 2015

Following discussion from #14, and aiming for OCA/l10n-spain#174, this module links events and products.

This implementation follows what was discussed before, and of course this is the first of a collection of modules to implement training in Odoo.

See README for instructions, please.

CC @pedrobaeza @elicoidal @dreispt @rafaelbn.

Thanks!

any product as long as:

* The product's *Is an event* checkbox is enabled.
* The product's event type is empty, or matches the event's.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/product's/Product

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure no 's is needed? 😕

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading again - you're right, it's OK.

@dreispt
Copy link
Member

dreispt commented Nov 27, 2015

👍 (code review, no test)

in products, which is added by the *event_sale* module, which installs
*sale*; so unless Odoo divides that module in smaller parts with smaller
dependencies, the only workaround is to give permissions to use *sale* to
nobody.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dreispt dreispt added this to the 8.0 milestone Nov 30, 2015
@yajo
Copy link
Member Author

yajo commented Nov 30, 2015

All fixed. I've got the next module on hold until this one is merged (I do not want to confuse reviewers anymore).

@dreispt
Copy link
Member

dreispt commented Nov 30, 2015

@yajo Please open a PR for it, just don't repeat this module in that PR. You can title it with [WIP]
The build will fail from the missing dependency, but no problem.

@rafaelbn
Copy link
Member

rafaelbn commented Dec 1, 2015

Tested, some questions:

  • In readme you say

    This module extends the functionality of events and products allowing their combination and the organization of a catalog of events.

    • If you have a catalog of events you would like to sell this catalog, isn't it?
    • How to create a SO from Event?
  • If you make a SO with a product which is an Event, why don't create a event when confirming it?

  • Go to reporting - Event - Event Analysis, must you add there the option of grouping by product?

  • Must you add a smart-button in product.product for events? In Odoo when there is a relation of two models usually this created actions and short-cuts for quicker and better info

2015-12-01_23-21-05

I'm trying to see usefulness as you see.

@dreispt
Copy link
Member

dreispt commented Dec 2, 2015

@rafaelbn SO are out of scope for this module: that logic is to be implemented in a separate module.

@rafaelbn
Copy link
Member

OK @dreispt . Sure.

What about this two:

  • Go to reporting - Event - Event Analysis, must you add there the option of grouping by product?
  • Must you add a smart-button in product.product for events? In Odoo when there is a relation of two models usually this created actions and short-cuts for quicker and better info

Thanks

@dreispt
Copy link
Member

dreispt commented Dec 20, 2015

@yajo, can you answer @rafaelbn ?

@yajo
Copy link
Member Author

yajo commented Dec 23, 2015

@rafaelbn

If you have a catalog of events you would like to sell this catalog, isn't it?
How to create a SO from Event?
If you make a SO with a product which is an Event, why don't create a event when confirming it?

Those seem reasonable things to do by this module, but its main purpose for now is to serve as a base for training courses, as discussed in #14.

Unlike @dreispt, I think this module is a good place to put that. He wants to avoid sale dependency, but since it is not possible (see README's known issues), why not just use this module for that?

In any case, the best I can do for now is to add @rafaelbn's suggestions to roadmap.

Go to reporting - Event - Event Analysis, must you add there the option of grouping by product?
Must you add a smart-button in product.product for events? In Odoo when there is a relation of two models usually this created actions and short-cuts for quicker and better info

Good points. I'll fix those ASAP.

@yajo
Copy link
Member Author

yajo commented Dec 24, 2015

All fixed, including new bugs I found and known issues section with @rafaelbn comments.

Jairo Llopis added 5 commits December 29, 2015 11:59
- Exceptions have new messages that can be understood when raised from
  product views.
- Exceptions support UTF-8 message formatting.
- Almost all product.product tests now test product.template too.
@yajo
Copy link
Member Author

yajo commented Dec 29, 2015

Last commits improve UX hiding fields for non-event users and adding search views and context default for event users.


* Wedding.
* Variants:
* Until 50 attendees.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

up to

@yajo
Copy link
Member Author

yajo commented Dec 30, 2015

Thanks @elicoidal, fixed.

Jairo Llopis added 3 commits December 30, 2015 09:51
Since this module serves as a base for many product-event modules, I
add this tab to give them a place to put their additional controls.

To make it more consistent with all those, I move the type of event
there.

Move event product filter to its place.

Merge product views in one.
@rafaelbn
Copy link
Member

Great! 👍

rafaelbn added a commit that referenced this pull request Jan 20, 2016
[8.0][event_product] New module to combine events and products
@rafaelbn rafaelbn merged commit 8034452 into OCA:8.0 Jan 20, 2016
@yajo yajo deleted the event_product branch January 25, 2016 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants