-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.0][event_product] New module to combine events and products #21
Conversation
any product as long as: | ||
|
||
* The product's *Is an event* checkbox is enabled. | ||
* The product's event type is empty, or matches the event's. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/product's/Product
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure no 's
is needed? 😕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading again - you're right, it's OK.
👍 (code review, no test) |
in products, which is added by the *event_sale* module, which installs | ||
*sale*; so unless Odoo divides that module in smaller parts with smaller | ||
dependencies, the only workaround is to give permissions to use *sale* to | ||
nobody. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
All fixed. I've got the next module on hold until this one is merged (I do not want to confuse reviewers anymore). |
@yajo Please open a PR for it, just don't repeat this module in that PR. You can title it with |
Tested, some questions:
I'm trying to see usefulness as you see. |
@rafaelbn SO are out of scope for this module: that logic is to be implemented in a separate module. |
OK @dreispt . Sure. What about this two:
Thanks |
Those seem reasonable things to do by this module, but its main purpose for now is to serve as a base for training courses, as discussed in #14. Unlike @dreispt, I think this module is a good place to put that. He wants to avoid In any case, the best I can do for now is to add @rafaelbn's suggestions to roadmap.
Good points. I'll fix those ASAP. |
All fixed, including new bugs I found and known issues section with @rafaelbn comments. |
- Exceptions have new messages that can be understood when raised from product views. - Exceptions support UTF-8 message formatting. - Almost all product.product tests now test product.template too.
Last commits improve UX hiding fields for non-event users and adding search views and context default for event users. |
|
||
* Wedding. | ||
* Variants: | ||
* Until 50 attendees. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
up to
Thanks @elicoidal, fixed. |
Since this module serves as a base for many product-event modules, I add this tab to give them a place to put their additional controls. To make it more consistent with all those, I move the type of event there. Move event product filter to its place. Merge product views in one.
Great! 👍 |
[8.0][event_product] New module to combine events and products
Following discussion from #14, and aiming for OCA/l10n-spain#174, this module links events and products.
This implementation follows what was discussed before, and of course this is the first of a collection of modules to implement training in Odoo.
See README for instructions, please.
CC @pedrobaeza @elicoidal @dreispt @rafaelbn.
Thanks!