Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] fieldservice_sale #1231

Merged
merged 102 commits into from
Nov 20, 2024
Merged

Conversation

EdgarRetes
Copy link
Contributor

@max3903 max3903 added this to the 18.0 milestone Oct 19, 2024
@max3903 max3903 self-assigned this Oct 19, 2024
@max3903
Copy link
Member

max3903 commented Oct 19, 2024

/ocabot migration fieldservice_sale

@OCA-git-bot OCA-git-bot mentioned this pull request Oct 19, 2024
24 tasks
@EdgarRetes EdgarRetes force-pushed the 18.0-mig-fieldservice_sale branch 2 times, most recently from a011982 to 26e2c63 Compare November 6, 2024 18:30
@EdgarRetes
Copy link
Contributor Author

@brian10048 Do you know how to prevent those warnings?

@EdgarRetes EdgarRetes force-pushed the 18.0-mig-fieldservice_sale branch from 16207d8 to 3ff8980 Compare November 6, 2024 19:43
@EdgarRetes
Copy link
Contributor Author

@brian10048 that worked, thanks. Can you check it?

@brian10048
Copy link
Contributor

My thoughts for improvement to make this module more cohesive with core Odoo features

We could remove the field field_service_tracking and combine its usage with the core Odoo field service_tracking

move the "Field Service Tracking" radio
Screenshot_20241107_222410

to the "Create on Order" dropdown
Screenshot_20241107_222343

This would require additional refactoring and migration scripts, but I think it is a good time to make the changes.

@max3903 would you guys be willing to work on the changes for this?

@max3903
Copy link
Member

max3903 commented Nov 8, 2024

What if someone wants to create a task and a FSM order? Same list but additional options?

@max3903
Copy link
Member

max3903 commented Nov 20, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-1231-by-max3903-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 20, 2024
Signed-off-by max3903
@OCA-git-bot
Copy link
Contributor

@max3903 your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-1231-by-max3903-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

osi-scampbell and others added 8 commits November 20, 2024 17:07
[IMP] Remove Duplicate Field
Added ability to link a product with FSM order template and create FSM
orders upon sale order confirmation
Added option to install fieldservice_sale module
ibuioli and others added 22 commits November 20, 2024 17:07
Currently translated at 100.0% (29 of 29 strings)

Translation: field-service-16.0/field-service-16.0-fieldservice_sale
Translate-URL: https://translation.odoo-community.org/projects/field-service-16-0/field-service-16-0-fieldservice_sale/es_AR/
Currently translated at 100.0% (29 of 29 strings)

Translation: field-service-16.0/field-service-16.0-fieldservice_sale
Translate-URL: https://translation.odoo-community.org/projects/field-service-16-0/field-service-16-0-fieldservice_sale/pt_BR/
Currently translated at 100.0% (29 of 29 strings)

Translation: field-service-16.0/field-service-16.0-fieldservice_sale
Translate-URL: https://translation.odoo-community.org/projects/field-service-16-0/field-service-16-0-fieldservice_sale/pt_BR/
Currently translated at 100.0% (29 of 29 strings)

Translation: field-service-16.0/field-service-16.0-fieldservice_sale
Translate-URL: https://translation.odoo-community.org/projects/field-service-16-0/field-service-16-0-fieldservice_sale/es/
Currently translated at 100.0% (29 of 29 strings)

Translation: field-service-16.0/field-service-16.0-fieldservice_sale
Translate-URL: https://translation.odoo-community.org/projects/field-service-16-0/field-service-16-0-fieldservice_sale/it/
Currently translated at 100.0% (29 of 29 strings)

Translation: field-service-16.0/field-service-16.0-fieldservice_sale
Translate-URL: https://translation.odoo-community.org/projects/field-service-16-0/field-service-16-0-fieldservice_sale/sk/
[FIX] fieldservice_sale

[FIX] fieldservice_sale
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: field-service-17.0/field-service-17.0-fieldservice_sale
Translate-URL: https://translation.odoo-community.org/projects/field-service-17-0/field-service-17-0-fieldservice_sale/
Currently translated at 100.0% (29 of 29 strings)

Translation: field-service-17.0/field-service-17.0-fieldservice_sale
Translate-URL: https://translation.odoo-community.org/projects/field-service-17-0/field-service-17-0-fieldservice_sale/it/
Currently translated at 100.0% (29 of 29 strings)

Translation: field-service-17.0/field-service-17.0-fieldservice_sale
Translate-URL: https://translation.odoo-community.org/projects/field-service-17-0/field-service-17-0-fieldservice_sale/es_AR/
Currently translated at 100.0% (29 of 29 strings)

Translation: field-service-17.0/field-service-17.0-fieldservice_sale
Translate-URL: https://translation.odoo-community.org/projects/field-service-17-0/field-service-17-0-fieldservice_sale/it/
@EdgarRetes EdgarRetes force-pushed the 18.0-mig-fieldservice_sale branch from 5cab653 to 1ba04a2 Compare November 20, 2024 23:08
@max3903
Copy link
Member

max3903 commented Nov 20, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-1231-by-max3903-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c966f3a into OCA:18.0 Nov 20, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 831cc1a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.