[ADD] fieldservice 0.0.1 #2

max3903 · 2018-09-07T21:56:11Z

#3

[FIX] Lint errors

max3903 · 2018-09-27T20:53:37Z

Todo:

Scheduled Starting Date --> Scheduled Start
Scheduled End Date --> Scheduled End
Field Service Person --> Assigned To (on order and route)
Duration --> Duration in hours
Starting Date --> Actual Start
End Date --> Actual End
Add stage Planned before En Route
On the route, show the sequence and the stage

[ADD] fsm.wizard

Update fsm_stage.xml

robertrottermann

I would like to have this merged, so we can start working with it

dreispt

A few style issues to fix, and a few design questions to clarify.

dreispt · 2018-10-01T12:30:29Z

fieldservice/__manifest__.py

+        'utm',
+        'rating',
+        'portal',
+        'web_timeline',


I believe we should be neat on dependencies: afaics we don't actually need utm, rating and portal right now.
These dependencies should added by a "FSM portal" module extension.

Regarding the web_timeline, I see the point - it makes the base module flashier.
But adding the additional dependency on the web OCA repo will add some trouble for people trying to install this from the FSM Github repo. So, it is not a showstopper, but I would rather separate the timeline into a different module (that can be made after this PR is merged).

dreispt · 2018-10-01T12:31:40Z

fieldservice/data/fsm_stage.xml

@@ -0,0 +1,49 @@
+<?xml version="1.0" encoding="utf-8"?>
+<odoo>


no_update="1"?
This should be suggested default data, not required data.

dreispt · 2018-10-01T12:34:17Z

fieldservice/models/fsm_location.py

+    _inherits = {'res.partner': 'partner_id'}
+    _description = 'Field Service Location'
+
+    description = fields.Char(string='Description')


If we use nameinstead of descriptionit will be automatically picked by name_get for record representation.

dreispt · 2018-10-01T12:39:06Z

fieldservice/models/fsm_order.py

+    color = fields.Integer('Color Index', default=0)
+
+    # Request
+    name = fields.Char(string='Name', required=True,


string="Title"?

dreispt · 2018-10-01T12:40:07Z

fieldservice/models/fsm_order.py

+                       default=lambda self: _('New'))
+    customer_id = fields.Many2one('res.partner', string='Customer',
+                                  domain=[('customer', '=', True)],
+                                  required=True,


Consider not making it mandatory in the base module.

dreispt · 2018-10-01T21:14:44Z

fieldservice/models/fsm_order.py

+    _name = 'fsm.order'
+    _description = 'Field Service Order'
+    _inherit = ['mail.thread', 'utm.mixin', 'rating.mixin',
+                'mail.activity.mixin', 'portal.mixin']


Do we really need all these at this point? (utm, rating and portal)

dreispt · 2018-10-01T21:17:00Z

fieldservice/models/service_request.py

+
+class ServiceLocation(models.Model):
+    _name = 'service.location'
+    _description = 'Location of the service'


Is this to indicate a precise location inside a fsm.location?
Should it be linked to a fsm_location_id?

dreispt · 2018-10-01T21:19:17Z

fieldservice/models/service_request.py

+
+class ServiceRequest(models.Model):
+    _name = 'service.request'
+    _description = 'Details of the Service Request'


Is this for Work Orders inside a Service Order?
Should it have a order_id field for the parent Order?

dreispt · 2018-10-01T21:25:16Z

fieldservice/views/fsm_order.xml

+                            name="action_cancel" string="Cancel"
+                            type="object" groups="fieldservice.group_fsm_dispatcher"
+                            attrs="{'invisible': [('stage_id', '=', %(fieldservice.fsm_stage_completed)d)]}"/>
+                    <field name="stage_id" widget="statusbar"/>


This is a hard coded stage list and workflow.
I would prefer a more flexible stage/state combination, more friendly for each customer's specific workflow.
We can have a separate discussion on this topic if you like.

dreispt · 2018-10-01T21:28:31Z

fieldservice/views/fsm_stage.xml

+                        </group>
+                        <group>
+                            <field name="fold"/>
+                        </group>


It would be good to include Teams in the FSM base module, and allow for different Stages for each team:
my "Installations" team might have a different workflow from my "Repairs" teams.

[FIX] PR comments

…raint (OCA#2)

[ADD] fieldservice

aac6717

max3903 changed the title ~~[ADD] fieldservice~~ [ADD] fieldservice v0.0.1 Sep 7, 2018

max3903 self-assigned this Sep 7, 2018

max3903 added this to the 11.0 milestone Sep 7, 2018

max3903 added the work in progress label Sep 7, 2018

max3903 added 2 commits September 7, 2018 17:13

[FIX] Lint errors

1169075

[IMP] Add Settings with Teams and Vehicles

7eace5f

max3903 removed their assignment Sep 10, 2018

Merge pull request #1 from ursais/11.0-field-service-max

a17ed56

[FIX] Lint errors

max3903 requested a review from wolfhall September 10, 2018 21:48

max3903 assigned osi-scampbell Sep 10, 2018

max3903 changed the title ~~[ADD] fieldservice v0.0.1~~ [ADD] fieldservice 0.0.1 Sep 11, 2018

osi-scampbell and others added 11 commits September 14, 2018 15:53

[ADD] Service Request

8c7dc78

[ADD] field service 0.0.1

2ac046c

[ADD] field service v0.0.1

5b58684

[ADD] Adding Service Requests

073e741

[ADD] Field Service Request

1fbb369

[ADD] Field Service Request

bb4a7f9

[ADD] Field Service Requests

d3b495e

[IMP] Split files

b9ea29d

[IMP] Add newline at EOF

894df09

[IMP] Add newline at EOF

85412ec

[FIX] External ID

abe1780

max3903 force-pushed the 11.0-field-service branch from 0067bb7 to abe1780 Compare September 21, 2018 14:54

max3903 added 6 commits September 21, 2018 09:56

[FIX] File sequence

6b83141

[FIX] Stage files

a29ac49

[FIX] Cleanup skill

01705f6

[FIX] model

14c5637

[FIX] View and PEP8

c915670

[FIX] Menu

00f8eeb

max3903 added 4 commits September 25, 2018 22:15

[FIX] PEP8 Errors

37849d3

[IMP] Formatting

2fa9ea4

[IMP] Menu sequencing

d941ada

[IMP] Split method

0bb79ab

max3903 and others added 4 commits September 27, 2018 15:59

[IMP] UI changes

60f5579

Merge pull request #8 from ursais/11.0-field-service-max

552064a

[ADD] fsm.wizard

Update fsm_stage.xml

16feced

Merge pull request #9 from ursais/11.0-field-service-max

70be57d

Update fsm_stage.xml

max3903 mentioned this pull request Oct 1, 2018

WIP #14

Closed

max3903 added needs review and removed work in progress labels Oct 1, 2018

robertrottermann approved these changes Oct 1, 2018

View reviewed changes

dreispt reviewed Oct 1, 2018

View reviewed changes

max3903 added 2 commits October 2, 2018 07:33

[FIX] PR comments

0028ac2

Merge pull request #10 from ursais/11.0-field-service-max

decaf6d

[FIX] PR comments

max3903 merged commit 133c573 into OCA:11.0 Oct 2, 2018

max3903 pushed a commit that referenced this pull request Dec 5, 2018

Merge pull request #2 from OCA/11.0

5c750a5

murtuzasaleh referenced this pull request in murtuzasaleh/field-service Mar 27, 2019

[ADD] fieldservice 0.0.1 (#2)

58a1b14

murtuzasaleh pushed a commit to SerpentConsultingServices/field-service that referenced this pull request Feb 26, 2020

[ADD] fieldservice 0.0.1 (OCA#2)

1b034af

murtuzasaleh pushed a commit to SerpentConsultingServices/field-service that referenced this pull request Mar 16, 2020

[ADD] fieldservice 0.0.1 (OCA#2)

b36741f

OCA-git-bot pushed a commit that referenced this pull request Mar 17, 2021

[ADD] fieldservice 0.0.1 (#2)

25a9bfd

baimont pushed a commit to acsone/field-service that referenced this pull request Apr 27, 2021

[FIX] ERROR: null value in column location_id violates not-null const…

6c868a8

…raint (OCA#2)

ankit-serpentcs pushed a commit to AmmarOfficewalaSerpentCS/field-service that referenced this pull request Mar 24, 2022

[ADD] fieldservice 0.0.1 (OCA#2)

272b0d2

victoralmau pushed a commit to Tecnativa/field-service that referenced this pull request Aug 8, 2022

[ADD] fieldservice 0.0.1 (OCA#2)

5fa9a03

victoralmau pushed a commit to Tecnativa/field-service that referenced this pull request Aug 9, 2022

[ADD] fieldservice 0.0.1 (OCA#2)

6eca8ea

victoralmau pushed a commit to Tecnativa/field-service that referenced this pull request Oct 5, 2022

[ADD] fieldservice 0.0.1 (OCA#2)

08c225f

max3903 added a commit that referenced this pull request Oct 10, 2022

[ADD] fieldservice 0.0.1 (#2)

5ca6138

OCA-git-bot pushed a commit that referenced this pull request Dec 18, 2023

[ADD] fieldservice 0.0.1 (#2)

d02b8a0

OCA-git-bot pushed a commit that referenced this pull request Oct 25, 2024

[ADD] fieldservice 0.0.1 (#2)

9358752

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD] fieldservice 0.0.1 #2

[ADD] fieldservice 0.0.1 #2

max3903 commented Sep 7, 2018 •

edited

Loading

max3903 commented Sep 27, 2018 •

edited

Loading

robertrottermann left a comment

dreispt left a comment

dreispt Oct 1, 2018

max3903 Oct 2, 2018

dreispt Oct 1, 2018

max3903 Oct 2, 2018

dreispt Oct 1, 2018

dreispt Oct 1, 2018

dreispt Oct 1, 2018

dreispt Oct 1, 2018

dreispt Oct 1, 2018

dreispt Oct 1, 2018

dreispt Oct 1, 2018

max3903 Oct 2, 2018

dreispt Oct 1, 2018

max3903 Oct 2, 2018

		@@ -0,0 +1,49 @@
		<?xml version="1.0" encoding="utf-8"?>
		<odoo>

[ADD] fieldservice 0.0.1 #2

[ADD] fieldservice 0.0.1 #2

Conversation

max3903 commented Sep 7, 2018 • edited Loading

max3903 commented Sep 27, 2018 • edited Loading

robertrottermann left a comment

Choose a reason for hiding this comment

dreispt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

max3903 commented Sep 7, 2018 •

edited

Loading

max3903 commented Sep 27, 2018 •

edited

Loading