Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OCA]12567 Location structure needs to reflect hierarchy of Buildings #22

Merged
merged 5 commits into from
Oct 12, 2018

Conversation

smangukiya
Copy link

Modified module:

field-service

@max3903 max3903 added this to the 11.0 milestone Oct 12, 2018
@max3903 max3903 self-requested a review October 12, 2018 18:34
@max3903 max3903 merged commit f0873d1 into OCA:11.0 Oct 12, 2018
@max3903 max3903 deleted the smangukiya_12567 branch October 12, 2018 19:12
@max3903 max3903 restored the smangukiya_12567 branch October 12, 2018 20:18
robertrottermann pushed a commit to redcor/field-service that referenced this pull request Oct 16, 2018
[ADD] fieldservice 0.0.1 (#2)

[UPD] addons table in README.md [ci skip]

[UPD] README.rst

[ADD] setup.py

REDCOR.md should list redcor enhancements

[IMP] README: explain what is FSM

[ADD] Vehicle (OCA#23)

* [ADD] Vehicle

[OCA]12567 Location structure needs to reflect hierarchy of Buildings (OCA#22)

* [IMP] Extend fsm.location object

[UPD] README.rst

[FIX] View

[ADD] red_fsm base, team handler

Option for enabling the red_fsm teams, new mwnu added under fieldservice settings to use red_fsm teams.

Removed incomplete method

[ADD] stages and stage sets

add website_support module

change module structure

[removed] remove website_support module, modified labels for fields and menu

modifications, cleaned code

Advanced stage transitions, option to add stage transitions for the stage sets

Tickets base. Support ticket base form, mail notification to employees and customers, etc

team: basic skills, person basic skills. Tickets: ticket from website

adjusted indentation

added plone code as a sample

team handler
robertrottermann pushed a commit to redcor/field-service that referenced this pull request Oct 16, 2018
@dreispt
Copy link
Member

dreispt commented Oct 18, 2018

We're building a bloated monolithic module here.
IMO this should be optional, and so separated into it's won addon module.

@etobella
Copy link
Member

That was also my comment on #23

@wolfhall
Copy link

I can see that with specific workflows, a building hierarchy is not needed. However, I had several customers who needed more details. when I worked with UPS and FedEx and large Utility companies one of the key problem was that the delivery or service point is often not the address point but a different location. The good thing about the model is that all the fields are optional. It would be great to have a configuration setting to turn some detailed location fields on/off.

@JordiBForgeFlow
Copy link
Member

In my past experience in service management / plant maintenance in SAP this would be done using a hierarchical structure, like the concept of Location in stock. In SAP they call it "Technical Location". And you can define a hierarchical tree that maps to physical places. The location does not necessarily need to be within your company.

IMHO adding so many fields as in this PR is never going to solve all the problems, whereas adding the field "Technical Location" would do.

@wolfhall
Copy link

I remember (a little fuzzy) using both functional and technical location for elevator equipment location representation. If I understand your suggestion you would like a generic, flexible hierarchy that allows us to define any "technical location" and tie it to a parent record (either another technical location or a functional location. Max and I are working with a customer right now who needs the details - we can see if this makes sense. I like the suggestion.

@dreispt
Copy link
Member

dreispt commented Oct 18, 2018

A Location hierarchy is important. But that’s not what’s happening here.
And there is a chance that the customer_id field is a duplication of the partner_id field.

@max3903
Copy link
Member

max3903 commented Oct 18, 2018

Please review #27

murtuzasaleh pushed a commit to murtuzasaleh/field-service that referenced this pull request Mar 27, 2019
OCA-git-bot pushed a commit that referenced this pull request Dec 31, 2019
[IMP] Fieldservice : raising a Validation Error if the sale order FSM location is empty and any sale order lines are set to any of the field service tracking options
murtuzasaleh pushed a commit to SerpentConsultingServices/field-service that referenced this pull request Feb 26, 2020
murtuzasaleh pushed a commit to SerpentConsultingServices/field-service that referenced this pull request Mar 16, 2020
hparfr referenced this pull request in akretion/field-service Mar 11, 2021
hparfr referenced this pull request in akretion/field-service Mar 11, 2021
ankit-serpentcs pushed a commit to AmmarOfficewalaSerpentCS/field-service that referenced this pull request Mar 24, 2022
victoralmau pushed a commit to Tecnativa/field-service that referenced this pull request Aug 8, 2022
victoralmau pushed a commit to Tecnativa/field-service that referenced this pull request Aug 9, 2022
victoralmau pushed a commit to Tecnativa/field-service that referenced this pull request Oct 5, 2022
max3903 pushed a commit that referenced this pull request Oct 10, 2022
OCA-git-bot pushed a commit that referenced this pull request Dec 18, 2023
OCA-git-bot pushed a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants