Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][FIX] fieldservice_sale - confirm quotation with section or note lines #914

Merged

Conversation

baimont
Copy link
Contributor

@baimont baimont commented Mar 10, 2022

When you use a product that should not create a fsm order and add a section line or a note line in a quotation, odoo raises an error asking for a FSM Location when you try to confirm the quotation. But you should be able to confirm the sale order without FSM Location since there will not be any field service creation.

fieldservicenoproduct
saleorderno

@baimont baimont force-pushed the 13.0-bai-fieldservice_sale-confirm_so_fix branch from 7e7795c to 76f18b7 Compare March 10, 2022 15:59
@baimont
Copy link
Contributor Author

baimont commented Mar 11, 2022

runboat fails : sbidoul/runboat#48

EDIT: fixed

Copy link

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baimont Could be a quick win to add a test with sections

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@hparfr
Copy link
Contributor

hparfr commented Mar 21, 2022

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-914-by-hparfr-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f7ffdf5 into OCA:13.0 Mar 21, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 617c7b2. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants