Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][IMP]helpdesk_mgmt_fieldservice: review fsm_order_close_wizard security #641

Closed
wants to merge 1 commit into from
Closed

[14.0][IMP]helpdesk_mgmt_fieldservice: review fsm_order_close_wizard security #641

wants to merge 1 commit into from

Commits on Oct 21, 2024

  1. [14.0][IMP]helpdesk_mgmt_fieldservice: review fsm_order_close_wizard … 

    …security

This commit reviews the security rules around the fsm_order_close_wizard.

The "Complete" button on the fsm.order triggered an access error for fieldservice.group_fsm_user_own. The commit allows fieldservice.group_fsm_user_own to use the wizard as well. However, the wizard is now only shown if the user also has write permission on the specific ticket (so as to play nice with a variety of setups, including helpdesk_mgmt.group_helpdesk_user_own).

If the user has permission to write on the ticket, the wizard will be shown as before; otherwise it will simply be skipped, but the fsm.order will be closed as it should.

There's also some code cleanup on the wizard, such as removing the unused team_id field.
    @aleuffre @PicchiSeba
    aleuffre authored and PicchiSeba committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    0172dd6 View commit details
    Browse the repository at this point in the history