-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][FW] hr_holidays_public: Deprecate use of employee_id in favour of partner_id #111
base: 17.0
Are you sure you want to change the base?
[17.0][FW] hr_holidays_public: Deprecate use of employee_id in favour of partner_id #111
Conversation
df2cf31
to
465668b
Compare
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
/ocabot merge major |
Hey, thanks for contributing! Proceeding to merge this for you. |
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-111-by-pedrobaeza-bump-major. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
Please rebase and check the CI. |
Helper functions to find public holidays did allow to use an hr.employee to filter country and states based on the employee address. Since only the address of the employee was used, modifying the functions to use a res.partner instead of an hr.employee allows more possibilities such as checking public holidays for customers and suppliers.
465668b
to
5e2871d
Compare
@pedrobaeza done |
Still red |
Helper functions to find public holidays did allow to use an hr.employee to filter country and states based on the employee address.
Since only the address of the employee was used, modifying the functions to use a res.partner instead of an hr.employee allows more possibilities such as checking public holidays for customers and suppliers.
Forward port of: