Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] hr_contract_employee_calendar_planning #1324

Open
wants to merge 14 commits into
base: 16.0
Choose a base branch
from

Conversation

jonasbuchholz
Copy link
Contributor

Migration to 16.0

@jonasbuchholz jonasbuchholz force-pushed the 16.0-mig_hr_contract_employee_calendar_planning branch from e844150 to 8181060 Compare December 18, 2023 14:16
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 28, 2024
@github-actions github-actions bot closed this Jun 2, 2024
@etobella etobella reopened this Jul 8, 2024
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 14, 2024
Copy link

@luisDIXMIT luisDIXMIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it looks good to me! However, in the migration proccess code has been added, such as overwitten create method and modifications to hr.contract.history view, in addition to the already modified hr.contrat view. The overwritten create method should be tested in order to pass all checks. Can you add that test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants