Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][ADD]hr_gamification_email_notification #869

Closed
wants to merge 2 commits into from
Closed

[12.0][ADD]hr_gamification_email_notification #869

wants to merge 2 commits into from

Conversation

Khalid-SerpentCS
Copy link

@Khalid-SerpentCS Khalid-SerpentCS commented Aug 13, 2020 •
edited
Loading

HR Gamification Email Notification

This module Sends Email to all the Employees with all the award given in
the last week.

@OCA-git-bot
Copy link
Contributor

Hi @o, @g, @e, @r, @i, @n, @ , @U, @p, @A, @s, @t, @c, @o, @s,
some modules you are maintaining are being modified, check this out!

@alexey-pelykh
Copy link
Contributor

@sbidoul ^ OCA bot gone crazy :D

@etobella
Copy link
Member

Why OSI?

@sbidoul
Copy link
Member

sbidoul commented Aug 13, 2020

The manifest of this module is broken in several ways. But okay, I guess the bot could survive to that :)

@sbidoul sbidoul mentioned this pull request Aug 13, 2020
Open
@Khalid-SerpentCS
Copy link
Author

Why OSI?

Solved!

bodedra
bodedra reviewed Aug 13, 2020
View reviewed changes
Copy link
Member

@bodedra bodedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Khalid-SerpentCS Would you please add a README folder and move manual content from README.rst file.

hr_gamification_email_notification/__manifest__.py Outdated Show resolved Hide resolved
bodedra
bodedra reviewed Aug 13, 2020
View reviewed changes
Copy link
Member

@bodedra bodedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the better visibility.

hr_gamification_email_notification/__manifest__.py Outdated Show resolved Hide resolved
@max3903 max3903 changed the title [12.0][ADD]hr_gamification_email_notification module [12.0][ADD]hr_gamification_email_notification Aug 14, 2020
@max3903 max3903 added this to the 12.0 milestone Aug 14, 2020
@max3903 max3903 self-requested a review August 14, 2020 13:16
bodedra
bodedra reviewed Aug 14, 2020
View reviewed changes
Copy link
Member

@bodedra bodedra left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. 👍 Please squash your commit.

@pedrobaeza
Copy link
Member

Or maybe make it a circle 😝

@Khalid-SerpentCS Khalid-SerpentCS force-pushed the 12.0-hr_gamification_email_notification branch from 16fe6eb to 43b415b Compare August 17, 2020 04:48
@dreispt
Copy link
Member

dreispt commented Sep 28, 2020

Hello, I did some tests on this, it it wasn't working - the message was created, but I didn't see it in the General channel.
I need to dig deeper to find fix suggestion.

@dreispt
Copy link
Member

dreispt commented Nov 9, 2020

@Khalid-SerpentCS Can you attend my last comment, please?

@Khalid-SerpentCS
Copy link
Author

Hello, I did some tests on this, it it wasn't working - the message was created, but I didn't see it in the General channel.
I need to dig deeper to find fix suggestion.

Hi Daniel, Mail is generated. But not going to general channel. You can find on Technical>Settings>Emails. Thanks

@dreispt
Copy link
Member

dreispt commented May 8, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-869-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 8, 2021
@OCA-git-bot
Merge PR #869 into 12.0
5efe006 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-869-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 24, 2022
@github-actions github-actions bot closed this Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max3903 max3903 max3903 left review comments

@bodedra bodedra bodedra approved these changes

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

Assignees

@Khalid-SerpentCS Khalid-SerpentCS

Labels
approved enhancement stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.