Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] intrastat_product #276

Merged
merged 183 commits into from
Sep 12, 2024

Conversation

dreispt
Copy link
Member

@dreispt dreispt commented May 25, 2024

Supersedes #261

Alexis de Lattre and others added 30 commits March 26, 2024 17:07
Rename report.intrastat.product to l10n.fr.report.intrastat.product (same for service and for lines) + migration scripts

Rename field country_id to origin_country_id (TODO : write mig script) and move this field from l10n_fr_intrastat_product to intrastat_product

Move intrastat_code and uom_id of report.intrastat.code from l10n_fr_intrastat_product to intrastat_product, as discussed with Luc de Meyer

Use display_name instead of an inherit of name_get (better use of new API) Inherit write and create of intrastat codes to remove spaces (patch by Luc De Meyer from Noviat) Add O2M fields from intrastat code to products and product categs
…cant, for instance, import files with name_search
* Update README.rst and translation files
* Add index=True on some fields on which we often search, as suggested by Yannick
* Remove description in __openerp__.py
* Move ACL from l10n_fr_intrastat_product module to intrastat_product module
* Large code re-engineering following the Akretion-Noviat code sprint on intrastat
  This code has been written both by Luc de Meyer and myself.
* Add first draft of code to generate decl lines
* Add product_origin_country_id on declaration/computation lines

  Copy incoterms and destination country from SO to invoice when invoicing from SO
  We need weight even when supplementary units is used
  Small cleanups and enhancements

* Add support for accessory costs

  Add default values for intrastat transaction on company
  Code cleanup

* If rounded weight is 0, put 1

  Take into account the taxes for B2C
  Small code cleanup

* Remove field exclude_from_intrastat

  Re-organise view of intrastat.product.declaration

* Add option intrastat_accessory_costs on company

  Set more fields as invisible (localisation should put them visible if they need it)
  Fix handling of suppl. units when hs_code is empty on invoice line (but set on product)
  Small usability enhancements

* Include selection of type of invoice in search, for better perf

  Isolate domain in a _prepare method, for easier inheritance
  WARNING: I changed the default selection of invoice type ; adapt it in your localization m
  odule if necessary
  Add intrastat_transaction_in_refund for company (not needed for France, but may be needed elsewhere)
  Add a log when an invoice line is skipped

* Include product code in warning msg on weight

* Inspired by the PR akretion/account-financial-reporting#8 of Luc de Meyer
* Improve logs and messages
* total_amount is a sum of integers, so it should be an integer
* Add transport mode in computation tree view
* FIX intrastat_country for invoices without src_dest_country_id
* FIX wrong model for seach method
* Use stock_picking_invoice_link for a better identification of the intrastat region

  With this commit, we now support the following scenario: I order to my supplier a quantity of 50 kg and he delivers/invoices 52kg ; odoo will create an additional invoice line of 2kg which is linked to the stock move, but not to any PO line.
* Modularise a piece of code
* Add ACL on hs.code to financial manager (I can't do it in product_harmonized_system because it doesn't depend on account)
* Handle scenario where an invoice has products with 0 value (samples for example) and shipping costs (accessory costs) with value > 0.
Because we can have intrastat unit that will never be mapped to an odoo unit (will always be set manually)
intrastat_base: Move company view params to account config page
* Add readonly on some fields when state of declaration is done
* Division by zero in computation of accessory costs
* Add FR translation
* Fix strings
* Minor code updates
* Small fixes in intrastat_base
* account_tax_template
Josep-s73 pushed a commit to Studio73/l10n-spain that referenced this pull request Jul 16, 2024
Josep-s73 pushed a commit to Studio73/l10n-spain that referenced this pull request Jul 16, 2024
Josep-s73 pushed a commit to Studio73/l10n-spain that referenced this pull request Jul 16, 2024
Josep-s73 pushed a commit to Studio73/l10n-spain that referenced this pull request Jul 16, 2024
Josep-s73 added a commit to Studio73/l10n-spain that referenced this pull request Jul 16, 2024
Josep-s73 added a commit to Studio73/l10n-spain that referenced this pull request Jul 16, 2024
Josep-s73 added a commit to Studio73/l10n-spain that referenced this pull request Jul 16, 2024
miguel-S73 pushed a commit to Studio73/l10n-spain that referenced this pull request Aug 14, 2024
@juanmagil
Copy link

When will this migration to the 17.0 branch be merged?

@dreispt dreispt force-pushed the akretion-17-mig-intrastat_product branch from d236db6 to f24ab29 Compare September 12, 2024 07:16
@dreispt dreispt force-pushed the akretion-17-mig-intrastat_product branch from 17c91bc to 0f77cf3 Compare September 12, 2024 07:26
@dreispt dreispt force-pushed the akretion-17-mig-intrastat_product branch 2 times, most recently from f9e5ba2 to 0c4f397 Compare September 12, 2024 07:42
@dreispt dreispt force-pushed the akretion-17-mig-intrastat_product branch from 0c4f397 to 4f1734a Compare September 12, 2024 07:54
@dreispt
Copy link
Member Author

dreispt commented Sep 12, 2024

Lint fixes were added and build is green now.
I believe it can be merged based on the approvals at #261

@gurneyalex
Copy link
Member

/ocabot migration intrastat_product

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Sep 12, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Sep 12, 2024
6 tasks
Copy link
Member

@gurneyalex gurneyalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for me.

@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-276-by-gurneyalex-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 820cf28 into OCA:17.0 Sep 12, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 26fae28. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.