[17.0][MIG] attachment_zipped_download: Migration to 17.0 #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[UPD] README.rst
[UPD] Update attachment_zipped_download.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-16.0/knowledge-16.0-attachment_zipped_download Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-attachment_zipped_download/
Translated using Weblate (Italian) Currently translated at 100.0% (4 of 4 strings) Translation: knowledge-16.0/knowledge-16.0-attachment_zipped_download Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-attachment_zipped_download/it/
attachment_zipped_download 16.0.1.0.1
Currently translated at 100.0% (4 of 4 strings) Translation: knowledge-16.0/knowledge-16.0-attachment_zipped_download Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-attachment_zipped_download/it/
Translated using Weblate (Croatian) Currently translated at 100.0% (4 of 4 strings) Translation: knowledge-16.0/knowledge-16.0-attachment_zipped_download Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-attachment_zipped_download/hr/
The previous code allowed any authenticated to retreive any attachment present
on odoo filesystem. So a WMS user could technically spoken download a zip with
accounting documents.
This implementation is calling attachemnt.check("read") to ensure access
right and use attachemnt.raw attribute to retreive file to archive which
(not test) should works with attachment saved somewhere else than the
local filesystem (s3 storage, pgsql large object storage...).
attachment_zipped_download 16.0.1.0.2
…ad mixin This helps to download multiple attachments from any models. [UPD] README.rst [UPD] Update attachment_zipped_download.pot [UPD] README.rst attachment_zipped_download 16.0.2.0.0 [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-16.0/knowledge-16.0-attachment_zipped_download Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-attachment_zipped_download/
Currently translated at 100.0% (7 of 7 strings) Translation: knowledge-16.0/knowledge-16.0-attachment_zipped_download Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-attachment_zipped_download/es/
Before the fix, 0 bytes would be transferred.
Currently translated at 100.0% (7 of 7 strings) Translation: knowledge-16.0/knowledge-16.0-attachment_zipped_download Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-attachment_zipped_download/it/ Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-16.0/knowledge-16.0-attachment_zipped_download Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-attachment_zipped_download/
[BOT] post-merge updates [BOT] post-merge updates
Translated using Weblate (Portuguese) Currently translated at 100.0% (7 of 7 strings) Translation: knowledge-16.0/knowledge-16.0-attachment_zipped_download Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-attachment_zipped_download/pt/
victoralmau
force-pushed
the
17.0-mig-attachment_zipped_download
branch
from
bc9b60d to
9bb905a
Compare
|
/ocabot migration attachment_zipped_download |
pedrobaeza
reviewed
Dec 21, 2024
| @@ -0,0 +1 @@ | |||
| odoo_test_helper | |||
There was a problem hiding this comment.
Looking at the use of this library, it seems to me very weird, as res.partner is in base module, so I don't think we need to use FakeModelLoader. Can you please check about this for removing unneeded dependencies?
There was a problem hiding this comment.
FakeModelLoader is still needed because even though res.partner is a base model, it is not extended by ir.attachment.action_download (because it is not needed); instead, FakeModelLoader is not needed in product_attachment_zipped_download.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration to 17.0
Please @pedrobaeza and @chienandalu can you review it?
@Tecnativa TT52268