Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0] [IMP] Validation of Before change state #1006

Merged
merged 1 commit into from
Oct 26, 2020
Merged

[12.0] [IMP] Validation of Before change state #1006

merged 1 commit into from
Oct 26, 2020

Conversation

luismalta
Copy link
Contributor

Adiciona a validação do método before_change_state, para garantir que é possível continuar com a troca de estado do documento

@OCA-git-bot
Copy link
Contributor

Hi @renatonlima,
some modules you are maintaining are being modified, check this out!

mileo
mileo approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@mileo mileo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boa sacada. Quando implementamos esse workflow realmente esquecemos disso.

@luismalta luismalta mentioned this pull request Oct 26, 2020
Merged
@mileo
Copy link
Member

mileo commented Oct 26, 2020

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-1006-by-mileo-bump-minor, awaiting test results.

@renatonlima
Copy link
Member

@mileo Did you see my PR #983? I had already made corrections and improvements related events and workflows

@mileo
Copy link
Member

mileo commented Oct 26, 2020

@mileo Did you see my PR #983? I had already made corrections and improvements related events and workflows

Hi, I was only able to look quickly, but I will review it until the middle of the week.

Looking back now I confirmed that he has no relationship with this PR.

@OCA-git-bot OCA-git-bot merged commit bfa48df into OCA:12.0 Oct 26, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 46746c8. Thanks a lot for contributing to OCA. ❤️

@mileo mileo deleted the imp/document_change_state branch February 28, 2021 02:00
mileo pushed a commit to kmee/l10n-brazil that referenced this pull request Mar 2, 2021
@OCA-git-bot
Merge PR OCA#1006 into 12.0
8ef0616 
Signed-off-by mileo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mileo mileo mileo approved these changes

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@luismalta @OCA-git-bot @mileo @renatonlima @marcelsavegnago