Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][FIX] Invoice refund names #1067

Merged
merged 2 commits into from
Jan 12, 2021
Merged

[12.0][FIX] Invoice refund names #1067

merged 2 commits into from
Jan 12, 2021

Conversation

luismalta
Copy link
Contributor

  • Rename return_operation_id to return_fiscal_operation_id
  • Rename _onchange_operation_id to _onchange_fiscal_operation_id

marcelsavegnago
marcelsavegnago requested changes Jan 8, 2021
View reviewed changes
Copy link
Member

@marcelsavegnago marcelsavegnago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabrielcardoso21 acho que precisa fazer um rebase por conta dos commits da PR #820

@gabrielcardoso21
Copy link
Contributor

@gabrielcardoso21 acho que precisa fazer um rebase por conta dos commits da PR #820

@luismalta pode dar um cherry-pick só dos últimos 3 commits em cima da nova 12.0 da oca?

@luismalta luismalta force-pushed the 12.0-fix-invoice-refund-names branch 2 times, most recently from 9e3aaa3 to 399febd Compare January 11, 2021 13:46
@mileo
Copy link
Member

mileo commented Jan 12, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-1067-by-mileo-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 03077dd into OCA:12.0 Jan 12, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 099d73e. Thanks a lot for contributing to OCA. ❤️

@mileo mileo deleted the 12.0-fix-invoice-refund-names branch February 28, 2021 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mileo mileo mileo approved these changes

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

@gabrielcardoso21 gabrielcardoso21 gabrielcardoso21 approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@luismalta @gabrielcardoso21 @mileo @OCA-git-bot @marcelsavegnago