Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Evento de cancelamento #1256

Closed
wants to merge 2 commits into from
Closed

[FIX] Evento de cancelamento #1256

wants to merge 2 commits into from

Conversation

mileo
Copy link
Member

@mileo mileo commented Mar 26, 2021

No description provided.

@mileo mileo mentioned this pull request Mar 26, 2021
Closed
@mileo mileo marked this pull request as ready for review March 26, 2021 15:27
@mileo
Copy link
Member Author

mileo commented Mar 26, 2021

@gabrielcardoso21 pode revisar novamente plz

cc: @renatonlima @rvalyi @marcelsavegnago

gabrielcardoso21
gabrielcardoso21 reviewed Mar 26, 2021
View reviewed changes
l10n_br_fiscal/models/document_eletronic.py
string="Cancelamento"
)

cancel_event_id = fields.Many2one(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When is this field filled?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found it akretion#171

@mileo
Copy link
Member Author

mileo commented Mar 26, 2021

Pessoal ainda estou resolvendo um problema nesse PR e testando ele junto com o da correção do fechamento fiscal
#1221

renatonlima
renatonlima requested changes Mar 29, 2021
View reviewed changes
Copy link
Member

@renatonlima renatonlima left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mileo,

Eu havia feito um refactoring porque os eventos fiscais não estão bem implementados, eu havia feito um PR #983, mas esse acabou deixando para depois porque na época precisava estabilizar o módulo de l10n_br_nfe e havia outros PRs importantes como o #1175 (Totais no mixin), #1146 (Edição da Fatura e Documento Fiscal)

Eu fiz o rebase do PR #983 e seria interessante resolver os problemas da implementação primeiro.

@mileo mileo mentioned this pull request Apr 10, 2021
Closed
@mileo mileo mentioned this pull request Apr 18, 2021
Closed
@marcelsavegnago
Copy link
Member

@mileo houve algum problema no runbot ?

This was referenced Apr 19, 2021
Closed
Merged
@mileo
Copy link
Member Author

mileo commented Apr 20, 2021

Pessoal estou encerrando este PR pois ele foi integrado no #1300 se possível revisem ele, minha previsão é finaliza-lo hoje até o fim da tarde.

@mileo mileo closed this Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelsavegnago marcelsavegnago marcelsavegnago left review comments

@gabrielcardoso21 gabrielcardoso21 gabrielcardoso21 approved these changes

@renatonlima renatonlima renatonlima requested changes

Assignees
No one assigned
Labels
12.0 bug work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mileo @marcelsavegnago @renatonlima @gabrielcardoso21