[15.0][FIX][l10n_br_fiscal] selection_add 'product' #2973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 24, 2024
Some modules of the repo depend on stock and have demo products of type 'product' (this type is added to product.template in the stock module). For some reason when running the tests, some inverse method fields then fail when reading 'product' value for the product type. It seems it is because l10n_br_fiscal doesn't depend on stock. But we don't want such a dependency. So to avoid the bug we add the 'product' value to the selection which seems like an acceptable workaround.
rvalyi
force-pushed
the
15.0-fiscal-product-type
branch
from
c4ef08a
to
e530b1c
Compare
mileo
approved these changes
Mar 25, 2024
marcelsavegnago
approved these changes
Mar 25, 2024
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
OCA-git-bot
added a commit
that referenced
this pull request
Mar 25, 2024
|
It looks like something changed on |
OCA-git-bot
added a commit
that referenced
this pull request
Mar 25, 2024
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 7f6939e. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some modules of the repo depend on stock and have
demo products of type 'product' (this type is added to product.template in the stock module).
For some reason when running the tests, some inverse method fields then fail when reading 'product' value for the product type. It seems it is because l10n_br_fiscal doesn't depend on stock. But we don't want such a dependency.
So to avoid the bug we add the 'product' value to the selection which seems like an acceptable workaround.
example of such bugs:
Has somebody a better idea?