Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0] [RFC] l10n_br_coa: refactor withholding (port from #3001 and #3015) #3007

Merged
merged 3 commits into from
Apr 18, 2024
Merged

[15.0] [RFC] l10n_br_coa: refactor withholding (port from #3001 and #3015) #3007

merged 3 commits into from
Apr 18, 2024

Conversation

marcelsavegnago
Copy link
Member

@marcelsavegnago marcelsavegnago commented Apr 9, 2024 •
edited
Loading

Port from #3001 and #3015

@OCA-git-bot
Copy link
Contributor

Hi @renatonlima, @mileo,
some modules you are maintaining are being modified, check this out!

@marcelsavegnago marcelsavegnago marked this pull request as draft April 9, 2024 22:58
@marcelsavegnago marcelsavegnago force-pushed the 15.0-rfc-l10n_br_coa-refactor-withholding branch from 9e1cdde to b5030bc Compare April 18, 2024 14:19
@marcelsavegnago marcelsavegnago marked this pull request as ready for review April 18, 2024 14:22
@marcelsavegnago marcelsavegnago force-pushed the 15.0-rfc-l10n_br_coa-refactor-withholding branch from b5030bc to 02f481b Compare April 18, 2024 15:59
@marcelsavegnago marcelsavegnago changed the title [15.0] [RFC] l10n_br_coa: refactor withholding (port from #3001) [15.0] [RFC] l10n_br_coa: refactor withholding (port from #3001 and #3015) Apr 18, 2024
@marcelsavegnago marcelsavegnago force-pushed the 15.0-rfc-l10n_br_coa-refactor-withholding branch from 02f481b to 17d8e86 Compare April 18, 2024 16:21
@rvalyi
Copy link
Member

rvalyi commented Apr 18, 2024

/ocabot merge major

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-3007-by-rvalyi-bump-major, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit a03ca87 into OCA:15.0 Apr 18, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a744f66. Thanks a lot for contributing to OCA. ❤️

@marcelsavegnago marcelsavegnago deleted the 15.0-rfc-l10n_br_coa-refactor-withholding branch April 18, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvalyi rvalyi rvalyi approved these changes

@kaynnan kaynnan kaynnan approved these changes

@renatonlima renatonlima Awaiting requested review from renatonlima

@antoniospneto antoniospneto Awaiting requested review from antoniospneto

@WesleyOliveira98 WesleyOliveira98 Awaiting requested review from WesleyOliveira98

@Matthwhy Matthwhy Awaiting requested review from Matthwhy

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcelsavegnago @OCA-git-bot @rvalyi @kaynnan