Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][l10n_br_fiscal] Oca port from 14.0 to 15.0 pr 3109 #3194

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

rvalyi
Copy link
Member

@rvalyi rvalyi commented Jul 22, 2024

port de #3109

@OCA-git-bot
Copy link
Contributor

Hi @renatonlima,
some modules you are maintaining are being modified, check this out!

@rvalyi
Copy link
Member Author

rvalyi commented Jul 22, 2024

passou os testes nao:

2024-07-22 02:02:14,333 388 INFO odoo odoo.addons.l10n_br_fiscal.tests.test_fiscal_document_generic: Starting TestFiscalDocumentGeneric.test_nfe_same_state ... 
2024-07-22 02:02:14,752 388 INFO odoo odoo.addons.l10n_br_fiscal.tests.test_fiscal_document_generic: ====================================================================== 
2024-07-22 02:02:14,752 388 ERROR odoo odoo.addons.l10n_br_fiscal.tests.test_fiscal_document_generic: FAIL: TestFiscalDocumentGeneric.test_nfe_same_state
Traceback (most recent call last):
  File "/__w/l10n-brazil/l10n-brazil/l10n_br_fiscal/tests/test_fiscal_document_generic.py", line 181, in test_nfe_same_state
    self.assertEqual(self.nfe_same_state.amount_price_gross, 3965)
AssertionError: 430.5 != 3965

@antoniospneto
Copy link
Contributor

wow, e tá bem grande a diferença com o valor esperado, vou dar uma conferida

@antoniospneto
Copy link
Contributor

@rvalyi @marcelsavegnago

Pelo que vi, o motivo é que faltou fazer o port da PR #3016

@rvalyi
Copy link
Member Author

rvalyi commented Jul 28, 2024

@antoniospneto eu dei um rebase mas deu o mesmo erro. Talvez seria bom arrumar esse para finalizar a migraçao do l10n_br_account para a v16

@antoniospneto
Copy link
Contributor

antoniospneto commented Jul 28, 2024

@rvalyi, encontrei o erro. Os dados de demonstração usados nesses testes tiveram os valores alterados. O registro "product.product_product_27" tinha um list_price de 3645.00 na versão 14.0, que mudou para 110.50 nas versões 15.0/16.0.

Vou refatorar esse teste na 14.0 para que não dependa desse registro específico. Após isso, você poderá fazer um cherry-pick aqui, e assim evitamos a necessidade de fazer alterações adicionais e aumentamos o diff com as outras versões.

@antoniospneto
Copy link
Contributor

@rvalyi se puder incluir o cherry-pick do commit 8ebf397
Conforme correção feita aqui: #3244

@rvalyi rvalyi force-pushed the oca-port-from-14.0-to-15.0-pr-3109 branch from e0bb519 to b374e36 Compare July 29, 2024 12:00
@rvalyi rvalyi marked this pull request as ready for review July 29, 2024 12:37
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rvalyi
Copy link
Member Author

rvalyi commented Jul 29, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-3194-by-rvalyi-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9678369 into OCA:15.0 Jul 29, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 79e3399. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants