Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] l10n_br_account: unidade de medida e valor da fatura #3340

Merged
merged 2 commits into from
Sep 6, 2024
Merged

[16.0][FIX] l10n_br_account: unidade de medida e valor da fatura #3340

merged 2 commits into from
Sep 6, 2024

Conversation

antoniospneto
Copy link
Contributor

@antoniospneto antoniospneto commented Sep 4, 2024 •
edited
Loading

Duas correções:

  1. A unidade de medida fiscal não tava sendo sincronizada com a unidade de medida do account.
  2. Em alguns casos, o valor total da fatura estava ficando negativo, impedindo a confirmação da mesma.

Essa PR ajuda a resolver os erros pendentes na migração do l10n_br_account_nfe. #3273

@antoniospneto antoniospneto mentioned this pull request Sep 4, 2024
Merged
@antoniospneto antoniospneto changed the title [16.0][FIX] l10n_br_account: correção pro uom_id e sinal do amount_currency [16.0][FIX] l10n_br_account: unidade de medida e valor da fatura Sep 4, 2024
rvalyi
rvalyi reviewed Sep 4, 2024
View reviewed changes
Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

Hi @renatonlima, @rvalyi,
some modules you are maintaining are being modified, check this out!

@rvalyi
Copy link
Member

rvalyi commented Sep 4, 2024

@antoniospneto importante se ligar que o port de #3311 ainda não entrou. Será se não afetou aqui?

@antoniospneto
Copy link
Contributor Author

antoniospneto commented Sep 4, 2024 •
edited
Loading

@antoniospneto importante se ligar que o port de #3311 ainda não entrou. Será se não afetou aqui?

Também senti a falta do #3311, mas não interfere nos casos desta, ainda é preciso destas duas correções.

@antoniospneto
Copy link
Contributor Author

cc @marcelsavegnago

@antoniospneto
Copy link
Contributor Author

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-3340-by-antoniospneto-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 6, 2024
@OCA-git-bot
Merge PR #3340 into 16.0
0781b6f 
Signed-off-by antoniospneto
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-3340-by-antoniospneto-bump-minor, awaiting test results.

@rvalyi
Copy link
Member

rvalyi commented Sep 6, 2024

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-3340-by-rvalyi-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 6, 2024
@OCA-git-bot
Merge PR #3340 into 16.0
6715e9d 
Signed-off-by rvalyi
@OCA-git-bot OCA-git-bot merged commit 08cbf7e into OCA:16.0 Sep 6, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c185f14. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot
Copy link
Contributor

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-3340-by-rvalyi-bump-minor, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 40852ce. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvalyi rvalyi rvalyi approved these changes

@marcelsavegnago marcelsavegnago Awaiting requested review from marcelsavegnago

Assignees
No one assigned
Labels
16.0 merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antoniospneto @OCA-git-bot @rvalyi