Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][IMP] l10n_br_nfe: set nfe40_IEST #3341

Merged
merged 1 commit into from
Sep 6, 2024
Merged

[14.0][IMP] l10n_br_nfe: set nfe40_IEST #3341

merged 1 commit into from
Sep 6, 2024

Conversation

DiegoParadeda
Copy link
Contributor

@DiegoParadeda DiegoParadeda commented Sep 5, 2024 •
edited
Loading

Objetivo

Definir o campo nfe40_IEST nos casos em que o estado de destino tenha um state_tax_number definido no cadastro da empresa.

Adicionei o campo no doc fiscal aqui:

image

XML + DANFE:

image

@OCA-git-bot
Copy link
Contributor

Hi @renatonlima, @rvalyi,
some modules you are maintaining are being modified, check this out!

antoniospneto

This comment was marked as resolved.

Sign in to view

rvalyi
rvalyi requested changes Sep 5, 2024
View reviewed changes
Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pela assinatura, o self é um recordset, mesmo que sendo chamado aqui com apenas um item. Nisso deveria ter um loop ou então um self.ensure_one()

@DiegoParadeda DiegoParadeda requested a review from rvalyi September 6, 2024 17:09
@antoniospneto
Copy link
Contributor

@DiegoParadeda

Consegue fazer um squash dos commits? você poderia ter usado git --amend ao invés de criar um novo commit.

@rvalyi
Copy link
Member

rvalyi commented Sep 6, 2024

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-3341-by-rvalyi-bump-minor, awaiting test results.

marcelsavegnago
marcelsavegnago approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@marcelsavegnago marcelsavegnago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot OCA-git-bot merged commit b5d0db9 into OCA:14.0 Sep 6, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3eda7cf. Thanks a lot for contributing to OCA. ❤️

@DiegoParadeda DiegoParadeda mentioned this pull request Sep 11, 2024
Merged
This was referenced Sep 30, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

@mileo mileo mileo approved these changes

@antoniospneto antoniospneto antoniospneto approved these changes

@rvalyi rvalyi rvalyi approved these changes

@renatonlima renatonlima Awaiting requested review from renatonlima

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DiegoParadeda @OCA-git-bot @antoniospneto @rvalyi @mileo @marcelsavegnago