[14.0][spec_driven_model][l10n_br_nfe] multi-schemas compatibility - round 1 #3424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvalyi
force-pushed
the
14.0-multi-schemas2-wip
branch
from
c6e9283
to
ce50fb7
Compare
rvalyi
force-pushed
the
14.0-multi-schemas2-wip
branch
2 times, most recently
from
76fcc85
to
c0b0ade
Compare
rvalyi
force-pushed
the
14.0-multi-schemas2-wip
branch
4 times, most recently
from
f21fccc
to
1518dc9
Compare
rvalyi
changed the title
rvalyi
force-pushed
the
14.0-multi-schemas2-wip
branch
2 times, most recently
from
7ce57f3
to
5721979
Compare
rvalyi
force-pushed
the
14.0-multi-schemas2-wip
branch
3 times, most recently
from
d4a0491
to
a603f7f
Compare
rvalyi
force-pushed
the
14.0-multi-schemas2-wip
branch
3 times, most recently
from
a8adb36
to
473df5a
Compare
|
Os 2 primeiros commits desse PR são meio que a abordagem minimalista e pode ser interessante olhar para entender. Porem eu vi que tinha que refatorar mais coisas e então eu fiz esse outro PR #3431 |
rvalyi
force-pushed
the
14.0-multi-schemas2-wip
branch
from
473df5a
to
2c0893d
Compare
|
deixei essa PR de rascunho aqui para ficar de referencia do primeiro passo do refactor.Porem não ta muito legal usar dict como eu fia aqui como _nfe40_spec_settings porque não é simples herdar o que tem dentro. E faltava botar um scope para varias outras propriedade que tavam por examplo no spec.mixin.nfe. Eu fiz essas coisas neste novo PR #3431 |
rvalyi
changed the title
|
fechando esse ja que foi substituido pelo #3431 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to make the spec_driven_model StackedModel behavior work well when using several schemas (or even versions) at the same time, for instance NFe with CTe and MDFe...
While working in this I found issues that I fixed in separated PR's:
EDIT: In the last commits, I replaced the references to generateDS by xsdata in the spec_driven_model methods and README.