[IMP] l10n_br_cnpj_search: refactors the test mocks #3438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tiago370
changed the title
mileo
approved these changes
Oct 14, 2024
|
/ocabot merge minor |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at dcaf65d. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pessoal, estou trabalhando nos testes do PR #3289 e senti uma necessidade de refatorar os mocks do l10n_br_cnpj_search.
O que esse PR faz é tirar os dicionários de mock dos testes e colocar no common.
O que me motivou fazer isso é:
Bom, isso é o que eu consegui pensar até agora, estou aberto a sugestões.
(marquei todos que interagiram no PR #3428)
@mileo , @rvalyi , @kaynnan , @CristianoMafraJunior , @antoniospneto