Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] l10n_br_account_nfe: _render_qweb_* migration #3439

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

CristianoMafraJunior
Copy link
Member

@CristianoMafraJunior CristianoMafraJunior commented Oct 15, 2024

Objetivo da PR

Esta PR resolve a Issue #3432, que causava o erro "got multiple values for data" ao tentar imprimir qualquer relatório.

Esse erro é similar ao corrigido anteriormente na PR #3255.

@OCA-git-bot
Copy link
Contributor

Hi @antoniospneto, @felipemotter, @mbcosta,
some modules you are maintaining are being modified, check this out!

@CristianoMafraJunior CristianoMafraJunior marked this pull request as draft October 15, 2024 13:42
@rvalyi
Copy link
Member

rvalyi commented Oct 15, 2024

@CristianoMafraJunior @antoniospneto eu não tinha visto que tinha esse override de novo no l10n_br_account_nfe, mas no l10n_br_nfe eu tinha feito a mudança para resolver isso que mudou na v16: 9ca0eb3

@CristianoMafraJunior CristianoMafraJunior force-pushed the 16.0-fix-render-pdf branch 3 times, most recently from a3ee84a to 7d3a0a9 Compare October 15, 2024 14:34
Copy link
Contributor

@antoniospneto antoniospneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ops, tinha aprovado mas falta ver os testes

@CristianoMafraJunior
Copy link
Member Author

[TESTE FUNCIONAL NO RUNBOAT]

TESTE_FUNCIONAL.mp4

@CristianoMafraJunior CristianoMafraJunior marked this pull request as ready for review October 15, 2024 15:32
Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antoniospneto
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-3439-by-antoniospneto-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d060319 into OCA:16.0 Oct 16, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 56c62cf. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants