[14.0][ADD] l10n_br_mdfe: add new module #3445

marcelsavegnago · 2024-10-16T13:20:00Z

This pull request introduces support for the Manifesto Eletrônico de Documentos Fiscais (MDFe) in the Brazilian fiscal module. The changes include adding new constants, updating data files, and creating new models and views to handle MDFe documents.

Major Changes:

MDFe Support:

Added MODELO_FISCAL_MDFE constant to l10n_br_fiscal/constants/fiscal.py.
Included MDFe document type in l10n_br_fiscal/data/l10n_br_fiscal.document.type.csv.
Created MDFe operation records in l10n_br_fiscal/data/operation_data.xml.

New Models and Fields:

Added document_supplement import in l10n_br_fiscal/models/__init__.py.
Introduced new fields key_random_code, key_check_digit, and total_weight in l10n_br_fiscal/models/document_mixin_fields.py.
Added currency_id, document_total_weight, and document_total_amount fields to l10n_br_fiscal/models/document_related.py.

MDFe Module:

Created l10n_br_mdfe module with initial setup and dependencies in l10n_br_mdfe/__manifest__.py.
Defined MDFe constants in l10n_br_mdfe/constants/mdfe.py.

Views and UI Enhancements:

Updated l10n_br_fiscal/views/document_related_view.xml to include total fields for MDFe.
Added total_weight field to delivery page in l10n_br_fiscal/views/document_view.xml.

OCA-git-bot · 2024-10-16T13:20:05Z

Hi @mileo, @renatonlima, @rvalyi,
some modules you are maintaining are being modified, check this out!

rvalyi · 2024-10-16T16:56:53Z

l10n_br_mdfe_spec/models/spec_models.py

@@ -7,13 +7,10 @@
 class MdfeSpecMixin(models.AbstractModel):


pode renomear o arquivo spec_mixin.py ? Eu fiz isso no PR do multi-esquemas, reflete mais o que tem dentro.

Pois o spec.mixin.schema eh algo que extende TODOS modelos geridos pro XSD, enquanto que o SpecModel e StackedModel sao apenas pro objetos Odoo nativos que tem que ser extendido por algum mixin do esquemas. Ja tem uma certa complexidade entao melhor ajudar com o nome das coisas.

rvalyi · 2024-10-16T18:34:53Z

l10n_br_mdfe/hooks.py

+
+def post_init_hook(cr, registry):
+ env = api.Environment(cr, SUPERUSER_ID, {})
+ env["mdfe.30.tmdfe_infnfe"]._register_hook()


Eu acho que pode tirar isso agora.

rvalyi · 2024-10-16T20:00:00Z

@marcelsavegnago o _register_hook não foi chamado pros objetos da mdfe. Esse problema foi depois de vc remover o hook apenas? Ele deveria fazer sozinho mas talvez ele cai naquele problema que eu comentei mais cedo de precisar de um loop para cada esquema no #3431.

Para as tabelas desses objetos existirem o _register_hook precisa ser chamado pelo menos uma vez para aquele esquema da mdfe. Normalmente ele deveria fazer sozinho, mas talvez caiu no caso que aquele mro() trouxe apenas as extensões da nfe e que ele parou apenas na primeira extensão "spec" da nfe no caso. Na pior se resolver de chamar o _register_hook em cima de um objeto da mdfe no hook.py, seria um workaround aceitável até fazer aquele loop no spec_driven_model.

rvalyi

@marcelsavegnago eu tinha errado no summary do manifest do modulo l10n_br_mdfe_spec (ta como CTe). Pode aproveitar para alterar o summary por algo do tipo: "MDF-e abstract models generated by xsdata-odoo from the oficial xsd" ou algo do tipo que achar melhor por favor? (eu acabei de ajustar dessa forma no summary do l10n_br_nfe_spec em #3461)

rvalyi

nos logs eu vi esse warning: "2024-10-21 13:08:15,686 535 WARNING odoo odoo.modules.registry: res.partner: inconsistent 'compute_sudo' for computed fields: mdfe30_CNPJ, mdfe30_idEstrangeiro, mdfe30_CPF, mdfe30_choice6, mdfe30_CEP, mdfe30_fone, mdfe30_IE, mdfe30_choice8, mdfe30_choice9, mdfe30_choice10, mdfe30_choice11, mdfe30_choice12 " Na NFe a gente conseguiu corrigir isso.

Tb é ruim usar esses padrões mdfe30_choiceXY, seria melhor botar um nome mdfe30_choice_<alguma coisa explicita> assim como foi feito nos campos choice da NFe.

marcelsavegnago · 2024-10-21T18:12:49Z

nos logs eu vi esse warning: "2024-10-21 13:08:15,686 535 WARNING odoo odoo.modules.registry: res.partner: inconsistent 'compute_sudo' for computed fields: mdfe30_CNPJ, mdfe30_idEstrangeiro, mdfe30_CPF, mdfe30_choice6, mdfe30_CEP, mdfe30_fone, mdfe30_IE, mdfe30_choice8, mdfe30_choice9, mdfe30_choice10, mdfe30_choice11, mdfe30_choice12 " Na NFe a gente conseguiu corrigir isso.

Tb é ruim usar esses padrões mdfe30_choiceXY, seria melhor botar um nome mdfe30_choice_<alguma coisa explicita> assim como foi feito nos campos choice da NFe.

Done

marcelsavegnago · 2024-10-21T18:21:24Z

@marcelsavegnago eu tinha errado no summary do manifest do modulo l10n_br_mdfe_spec (ta como CTe). Pode aproveitar para alterar o summary por algo do tipo: "MDF-e abstract models generated by xsdata-odoo from the oficial xsd" ou algo do tipo que achar melhor por favor? (eu acabei de ajustar dessa forma no summary do l10n_br_nfe_spec em #3461)

Done

…valida_xml

rvalyi · 2024-10-21T21:30:00Z

@marcelsavegnago parabéns pelo trabalho!! Ficou OK para revisar?

rvalyi · 2024-10-21T21:34:30Z

l10n_br_mdfe/models/res_company.py

+ def _build_attr(self, node, fields, vals, path, attr):
+ if attr[0] == "enderEmit" and self.env.context.get("edoc_type") == "in":
+ # we don't want to try build a related partner_id for enderEmit
+ # when importing an NFe


Corrigir NFe -> MDFe

rvalyi requested changes Oct 16, 2024

View reviewed changes

marcelsavegnago force-pushed the 14.0-add-l10n_br_mdfe_rebased-escodoo-wip-withothercommits-spec-nfe-and-others3 branch from 2be2b5c to cbf090a Compare October 16, 2024 17:33

rvalyi requested changes Oct 16, 2024

View reviewed changes

marcelsavegnago force-pushed the 14.0-add-l10n_br_mdfe_rebased-escodoo-wip-withothercommits-spec-nfe-and-others3 branch 5 times, most recently from 46cbd92 to a4727ac Compare October 17, 2024 18:27

felipezago and others added 5 commits October 18, 2024 12:24

[ADD] l10n_br_mdfe: add new module

2ea913b

[IMP] l10n_br_fiscal: mdfe serie, demo and others

6c8cddb

[IMP] l10n_br_fiscal: imp document_supplement

6ca4471

[IMP] l10n_br_fiscal_edi: add MODELO_FISCAL_MDFE on workflow

02718bc

[RFC] l10n_br_mdfe: refactor, fixes and others

8f447d6

marcelsavegnago force-pushed the 14.0-add-l10n_br_mdfe_rebased-escodoo-wip-withothercommits-spec-nfe-and-others3 branch 3 times, most recently from 3bbd0a7 to d9bcf20 Compare October 19, 2024 18:50

This was referenced Oct 20, 2024

[WIP][14.0][ADD] l10n_br_mdfe rebased #3140

Closed

[14.0][NEW] l10n_br_mdfe #2603

Closed

marcelsavegnago force-pushed the 14.0-add-l10n_br_mdfe_rebased-escodoo-wip-withothercommits-spec-nfe-and-others3 branch from 86c8bbe to 027a274 Compare October 20, 2024 19:40

rvalyi requested changes Oct 20, 2024

View reviewed changes

marcelsavegnago force-pushed the 14.0-add-l10n_br_mdfe_rebased-escodoo-wip-withothercommits-spec-nfe-and-others3 branch 5 times, most recently from 32a5ba0 to ad38578 Compare October 21, 2024 12:58

rvalyi requested changes Oct 21, 2024

View reviewed changes

marcelsavegnago force-pushed the 14.0-add-l10n_br_mdfe_rebased-escodoo-wip-withothercommits-spec-nfe-and-others3 branch 2 times, most recently from 714f1be to 23879d9 Compare October 21, 2024 13:28

marcelsavegnago force-pushed the 14.0-add-l10n_br_mdfe_rebased-escodoo-wip-withothercommits-spec-nfe-and-others3 branch 5 times, most recently from 82c5121 to f2346a1 Compare October 21, 2024 18:12

marcelsavegnago force-pushed the 14.0-add-l10n_br_mdfe_rebased-escodoo-wip-withothercommits-spec-nfe-and-others3 branch 3 times, most recently from 9220390 to 1a7defd Compare October 21, 2024 19:05

marcelsavegnago marked this pull request as ready for review October 21, 2024 19:32

marcelsavegnago force-pushed the 14.0-add-l10n_br_mdfe_rebased-escodoo-wip-withothercommits-spec-nfe-and-others3 branch from 1a7defd to 29d7794 Compare October 21, 2024 21:09

marcelsavegnago added 9 commits October 21, 2024 18:11

[RFC] l10n_br_mdfe: refactor for multi-schema support

3e20fed

[IMP] l10n_br_mdfe: add akretion and escodoo on contributors file

0f386a0

[IMP] l10n_br_fiscal: add manifesto fiscal operation and operation line

82aa21c

[IMP] l10n_br_nfe: set product.product _nfe40_odoo_module

ab5e0a1

[RFC] l10n_br_nfe: document_supplement refactor

8401276

[FIX] l10n_br_nfe: add super on _generate_key, _document_export and _…

3fe2595

…valida_xml

[RFC] l10n_br_mdfe_spec: refactor for multi-schema support

d833481

[FIX] l10n_br_mdfe_spec: fix summary and module description file

ee02801

[FIX] l10n_br_nfse_focus: fix tests

7796978

marcelsavegnago force-pushed the 14.0-add-l10n_br_mdfe_rebased-escodoo-wip-withothercommits-spec-nfe-and-others3 branch from 29d7794 to 7796978 Compare October 21, 2024 21:12

rvalyi reviewed Oct 21, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0][ADD] l10n_br_mdfe: add new module #3445

[14.0][ADD] l10n_br_mdfe: add new module #3445

marcelsavegnago commented Oct 16, 2024 •

edited

Loading

OCA-git-bot commented Oct 16, 2024

rvalyi Oct 16, 2024

marcelsavegnago Oct 16, 2024

rvalyi Oct 16, 2024

marcelsavegnago Oct 16, 2024

rvalyi commented Oct 16, 2024 •

edited

Loading

rvalyi left a comment •

edited

Loading

rvalyi left a comment •

edited

Loading

marcelsavegnago commented Oct 21, 2024

marcelsavegnago commented Oct 21, 2024

rvalyi commented Oct 21, 2024

rvalyi Oct 21, 2024

[14.0][ADD] l10n_br_mdfe: add new module #3445

Are you sure you want to change the base?

[14.0][ADD] l10n_br_mdfe: add new module #3445

Conversation

marcelsavegnago commented Oct 16, 2024 • edited Loading

Major Changes:

MDFe Support:

New Models and Fields:

MDFe Module:

Views and UI Enhancements:

OCA-git-bot commented Oct 16, 2024

rvalyi Oct 16, 2024

Choose a reason for hiding this comment

marcelsavegnago Oct 16, 2024

Choose a reason for hiding this comment

rvalyi Oct 16, 2024

Choose a reason for hiding this comment

marcelsavegnago Oct 16, 2024

Choose a reason for hiding this comment

rvalyi commented Oct 16, 2024 • edited Loading

rvalyi left a comment • edited Loading

Choose a reason for hiding this comment

rvalyi left a comment • edited Loading

Choose a reason for hiding this comment

marcelsavegnago commented Oct 21, 2024

marcelsavegnago commented Oct 21, 2024

rvalyi commented Oct 21, 2024

rvalyi Oct 21, 2024

Choose a reason for hiding this comment

marcelsavegnago commented Oct 16, 2024 •

edited

Loading

rvalyi commented Oct 16, 2024 •

edited

Loading

rvalyi left a comment •

edited

Loading

rvalyi left a comment •

edited

Loading