[12.0][FIX] fiscal document return #960
Conversation
renatonlima
commented
Sep 17, 2020
renatonlima
commented
- Não deve chamar o onchange do product_id na linha ao fazer as linhas de devolução (porque deve pegar os dados fiscais exatamente como da nota original);
- O _create_return espera vários registros, mas é chamdo pelo método action_create_return tem um ensure_one();
- Implementado uma validação caso a operação fiscal não tenha a operação de retorno definida
- Não deveria gravar a operação fiscal do cabeçalho da NF-e em todas as linhas, pois cada linha pode ter operações fiscais diferentes e consequentemente operações fiscais de retorno diferentes.
renatonlima
force-pushed
the
12.0-fix-fiscal-document-return
branch
2 times, most recently
from
4b73f2c
to
edaface
Compare
l10n_br_fiscal/models/document.py
Outdated
| fsc_op = record.fiscal_operation_id.return_fiscal_operation_id | ||
| if not fsc_op: | ||
| raise ValidationError(_( | ||
| "The fiscal operation {} there is not Return Fiscal " |
There was a problem hiding this comment.
| "The fiscal operation {} there is not Return Fiscal " | |
| "The Fiscal Operation {} there has no Return Fiscal " |
renatonlima
force-pushed
the
12.0-fix-fiscal-document-return
branch
from
edaface
to
d0bc21a
Compare
renatonlima
force-pushed
the
12.0-fix-fiscal-document-return
branch
from
d0bc21a
to
b642481
Compare
|
The Travis error was unrelated, it was due to a currency server connnection failure. I restarted the build to ensure it's green. |
There was a problem hiding this comment.
Realmente ta quebrando o teste do return https://travis-ci.org/github/OCA/l10n-brazil/jobs/728192636#L1912
cc @renatonlima
renatonlima
force-pushed
the
12.0-fix-fiscal-document-return
branch
2 times, most recently
from
0624d9c
to
98926f4
Compare
l10n_br_fiscal/models/document.py
Outdated
| if not fsc_op: | ||
| raise ValidationError(_( | ||
| "The fiscal operation {} has no Return Fiscal " | ||
| "Operation definied".format(record.fiscal_operation_id))) |
There was a problem hiding this comment.
definied -> defined
also be consistent if you use cap letters for Fiscal Operation or not in the same sentence (Odoo uses to do it but not mandatory).
l10n_br_fiscal/models/document.py
Outdated
| if not fsc_op_line: | ||
| raise ValidationError(_( | ||
| "The fiscal operation {} has no Return Fiscal " | ||
| "Operation definied".format(l.fiscal_operation_id))) |
There was a problem hiding this comment.
definied -> defined
also be consistent if you use cap letters for Fiscal Operation or not in the same sentence (Odoo uses to do it but not mandatory).
renatonlima
force-pushed
the
12.0-fix-fiscal-document-return
branch
from
98926f4
to
b8f8b16
Compare
|
This PR has the |
|
/ocabot merge minor |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 37aa56b. Thanks a lot for contributing to OCA. ❤️ |
