Merge PR #2446 into 14.0

Signed-off-by TheMule71

l10n_it_fatturapa_in/models/attachment.py

@@ -1,5 +1,3 @@
-import base64
-
 from odoo import _, api, fields, models
 from odoo.tools import format_date
 
@@ -135,7 +133,7 @@ def extract_attachments(self, AttachmentsData, invoice_id):
             content = attach.Attachment.encode()
             _attach_dict = {
                 "name": name,
-                "datas": base64.b64encode(content),
+                "datas": content,
                 "description": attach.DescrizioneAttachment or "",
                 "compression": attach.AlgoritmoCompressione or "",
                 "format": attach.FormatoAttachment or "",

l10n_it_fatturapa_in/tests/test_import_fatturapa_xml.py

@@ -3,6 +3,7 @@
 from psycopg2 import IntegrityError
 
 from odoo.exceptions import UserError
+from odoo.modules import get_module_resource
 from odoo.tests import Form
 from odoo.tools import mute_logger
 
@@ -103,6 +104,17 @@ def test_01_xml_import(self):
         self.assertEqual(invoice.ftpa_incoterms, "DAP")
         self.assertEqual(invoice.fiscal_document_type_id.code, "TD01")
         self.assertTrue(invoice.art73)
+
+        # verify if attached documents are correctly imported
+        attachments = invoice.fatturapa_doc_attachments
+        self.assertEqual(len(attachments), 1)
+        orig_attachment_path = get_module_resource(
+            "l10n_it_fatturapa_in", "tests", "data", "test.png"
+        )
+        with open(orig_attachment_path, "rb") as orig_attachment:
+            orig_attachment_data = orig_attachment.read()
+            self.assertEqual(attachments[0].raw, orig_attachment_data)
+
         # allow following tests to reuse the same XML file
         invoice.ref = invoice.payment_reference = "14011"