[MIG] l10n_it_account_tax_kind: Migration to 18.0

l10n_it_account_tax_kind/README.rst

@@ -17,13 +17,13 @@ ITA - Natura delle aliquote IVA
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fl10n--italy-lightgray.png?logo=github
-    :target: https://github.com/OCA/l10n-italy/tree/16.0/l10n_it_account_tax_kind
+    :target: https://github.com/OCA/l10n-italy/tree/18.0/l10n_it_account_tax_kind
     :alt: OCA/l10n-italy
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/l10n-italy-16-0/l10n-italy-16-0-l10n_it_account_tax_kind
+    :target: https://translation.odoo-community.org/projects/l10n-italy-18-0/l10n-italy-18-0-l10n_it_account_tax_kind
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/l10n-italy&target_branch=16.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/l10n-italy&target_branch=18.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -91,7 +91,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/l10n-italy/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/l10n-italy/issues/new?body=module:%20l10n_it_account_tax_kind%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/l10n-italy/issues/new?body=module:%20l10n_it_account_tax_kind%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -125,6 +125,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.
 
-This module is part of the `OCA/l10n-italy <https://github.com/OCA/l10n-italy/tree/16.0/l10n_it_account_tax_kind>`_ project on GitHub.
+This module is part of the `OCA/l10n-italy <https://github.com/OCA/l10n-italy/tree/18.0/l10n_it_account_tax_kind>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

l10n_it_account_tax_kind/__manifest__.py

@@ -8,15 +8,15 @@
 
 {
     "name": "ITA - Natura delle aliquote IVA",
-    "version": "16.0.1.0.1",
+    "version": "18.0.1.0.0",
     "development_status": "Production/Stable",
     "category": "Localization/Italy",
     "summary": "Gestione natura delle aliquote IVA",
     "author": "Odoo Community Association (OCA), Apulia Software s.r.l",
     "website": "https://github.com/OCA/l10n-italy",
     "license": "AGPL-3",
     "depends": [
-        "l10n_it_account",
+        "l10n_it",
     ],
     "data": [
         "view/account_tax_kind_view.xml",

l10n_it_account_tax_kind/migrations/18.0.1.0.0/pre-migrate.py

@@ -0,0 +1,55 @@
+# Dinamiche Aziendali srl (<http://www.dinamicheaziendali.it/>)
+# @author: Giuseppe Borruso (gborruso@dinamicheaziendali.it)
+# License GPL-3.0 or later (http://www.gnu.org/licenses/gpl.html).
+
+from openupgradelib import openupgrade
+from psycopg2 import sql
+
+from odoo import SUPERUSER_ID, api
+
+MODEL = "account.tax"
+OLD_MODEL = "account.tax.kind"
+RENAMED_FIELDS = [
+    (
+        "law_reference",
+        "l10n_it_law_reference",
+    ),
+]
+
+
+def migrate(cr, version):
+    env = api.Environment(cr, SUPERUSER_ID, {})
+
+    openupgrade.logged_query(
+        env.cr,
+        sql.SQL(f"""
+            UPDATE
+                {MODEL.replace(".", "_")}
+            SET
+                l10n_it_exempt_reason = kind_id.code
+            FROM
+                {OLD_MODEL.replace(".", "_")} AS kind
+            WHERE
+                {MODEL.replace(".", "_")}.kind_id = kind.id
+                AND {MODEL.replace(".", "_")}.kind_id IS NOT NULL
+        """),
+    )
+
+    field_spec = []
+    for renamed_field in RENAMED_FIELDS:
+        old_field, new_field = renamed_field
+        field_spec.append(
+            (
+                MODEL,
+                MODEL.replace(".", "_"),
+                old_field,
+                new_field,
+            )
+        )
+    openupgrade.rename_fields(
+        env,
+        field_spec,
+    )
+
+    module = env["ir.module.module"].search([("name", "=", "l10n_it_account_tax_kind")])
+    module.button_immediate_uninstall()

l10n_it_account_tax_kind/model/account_tax_kind.py

@@ -1,4 +1,4 @@
-from odoo import fields, models
+from odoo import api, fields, models
 
 
 class AccountTaxKind(models.Model):
@@ -9,8 +9,7 @@ class AccountTaxKind(models.Model):
     code = fields.Char(size=4, required=True)
     name = fields.Char(required=True)
 
-    def name_get(self):
-        res = []
+    @api.depends("code", "name")
+    def _compute_display_name(self):
         for tax_kind in self:
-            res.append((tax_kind.id, f"[{tax_kind.code}] {tax_kind.name}"))
-        return res
+            tax_kind.display_name = f"[{tax_kind.code}] {tax_kind.name}"

l10n_it_account_tax_kind/security/ir.model.access.csv

@@ -1,3 +1,3 @@
 "id","name","model_id:id","group_id:id","perm_read","perm_write","perm_create","perm_unlink"
-"access_account_tax_kind_user","account_tax_kind user","model_account_tax_kind",,1,0,0,0
+"access_account_tax_kind_user","account_tax_kind user","model_account_tax_kind","base.group_user",1,0,0,0
 "access_account_tax_kind_manager","account_tax_kind manager","model_account_tax_kind","account.group_account_invoice",1,1,1,1

l10n_it_account_tax_kind/static/description/index.html

@@ -8,10 +8,11 @@
 
 /*
 :Author: David Goodger (goodger@python.org)
-:Id: $Id: html4css1.css 8954 2022-01-20 10:10:25Z milde $
+:Id: $Id: html4css1.css 9511 2024-01-13 09:50:07Z milde $
 :Copyright: This stylesheet has been placed in the public domain.
 
 Default cascading style sheet for the HTML output of Docutils.
+Despite the name, some widely supported CSS2 features are used.
 
 See https://docutils.sourceforge.io/docs/howto/html-stylesheets.html for how to
 customize this style sheet.
@@ -274,7 +275,7 @@
   margin-left: 2em ;
   margin-right: 2em }
 
-pre.code .ln { color: grey; } /* line numbers */
+pre.code .ln { color: gray; } /* line numbers */
 pre.code, code { background-color: #eeeeee }
 pre.code .comment, code .comment { color: #5C6576 }
 pre.code .keyword, code .keyword { color: #3B0D06; font-weight: bold }
@@ -300,7 +301,7 @@
 span.pre {
   white-space: pre }
 
-span.problematic {
+span.problematic, pre.problematic {
   color: red }
 
 span.section-subtitle {
@@ -368,7 +369,7 @@ <h1 class="title">ITA - Natura delle aliquote IVA</h1>
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! source digest: sha256:3ef9107313814378f2d62f26b54735cbe6c4c582fd7184d74b0d41fdc58a5c4f
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Production/Stable" src="https://img.shields.io/badge/maturity-Production%2FStable-green.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/l10n-italy/tree/16.0/l10n_it_account_tax_kind"><img alt="OCA/l10n-italy" src="https://img.shields.io/badge/github-OCA%2Fl10n--italy-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/l10n-italy-16-0/l10n-italy-16-0-l10n_it_account_tax_kind"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/l10n-italy&amp;target_branch=16.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Production/Stable" src="https://img.shields.io/badge/maturity-Production%2FStable-green.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/l10n-italy/tree/18.0/l10n_it_account_tax_kind"><img alt="OCA/l10n-italy" src="https://img.shields.io/badge/github-OCA%2Fl10n--italy-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/l10n-italy-18-0/l10n-italy-18-0-l10n_it_account_tax_kind"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/l10n-italy&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p><strong>Italiano</strong></p>
 <p>Questo modulo estende la funzionalità delle imposte.</p>
 <p>Con questo modulo è possibile assegnare un tipo di esenzione per ogni
@@ -430,7 +431,7 @@ <h1><a class="toc-backref" href="#toc-entry-3">Bug Tracker</a></h1>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/l10n-italy/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/l10n-italy/issues/new?body=module:%20l10n_it_account_tax_kind%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/l10n-italy/issues/new?body=module:%20l10n_it_account_tax_kind%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
@@ -454,11 +455,13 @@ <h2><a class="toc-backref" href="#toc-entry-6">Contributors</a></h2>
 <div class="section" id="maintainers">
 <h2><a class="toc-backref" href="#toc-entry-7">Maintainers</a></h2>
 <p>This module is maintained by the OCA.</p>
-<a class="reference external image-reference" href="https://odoo-community.org"><img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" /></a>
+<a class="reference external image-reference" href="https://odoo-community.org">
+<img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" />
+</a>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/l10n-italy/tree/16.0/l10n_it_account_tax_kind">OCA/l10n-italy</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/l10n-italy/tree/18.0/l10n_it_account_tax_kind">OCA/l10n-italy</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>

l10n_it_account_tax_kind/tests/test_account_tax_kind.py

@@ -2,7 +2,7 @@
 
 from odoo.tests.common import TransactionCase
 
-from odoo.addons.l10n_it_account.tools.account_tools import fpa_schema_get_enum
+# from odoo.addons.l10n_it_account.tools.account_tools import fpa_schema_get_enum
 
 
 class TestAccountTaxKind(TransactionCase):
@@ -21,13 +21,13 @@ def test_name_search(self):
         result = self.env["account.tax.kind"].name_search("Escluse ex art. 15")
         self.assertEqual(result and result[0][0], self.tax_kind_n1.id)
 
-    def test_compare_with_fpa_schema(self):
-        """Check that the values we define in this module are
-        the same as those defined in FPA xsd"""
-
-        my_codes = self.env["account.tax.kind"].search([]).mapped("code")
-
-        # from fatturapa xml Schema
-        xsd_codes = [code for code, descr in fpa_schema_get_enum("NaturaType")]
-
-        self.assertCountEqual(my_codes, xsd_codes)
+    # def test_compare_with_fpa_schema(self):
+    #     """Check that the values we define in this module are
+    #     the same as those defined in FPA xsd"""
+    #
+    #     my_codes = self.env["account.tax.kind"].search([]).mapped("code")
+    #
+    #     # from fatturapa xml Schema
+    #     xsd_codes = [code for code, descr in fpa_schema_get_enum("NaturaType")]
+    #
+    #     self.assertCountEqual(my_codes, xsd_codes)

l10n_it_account_tax_kind/view/account_tax_kind_view.xml

@@ -1,13 +1,13 @@
 <?xml version="1.0" ?>
 <odoo>
     <record id="view_account_tax_kind_tree" model="ir.ui.view">
-        <field name="name">account.tax.kind.tree</field>
+        <field name="name">account.tax.kind.list</field>
         <field name="model">account.tax.kind</field>
         <field name="arch" type="xml">
-            <tree>
+            <list>
                 <field name="code" />
                 <field name="name" />
-            </tree>
+            </list>
         </field>
     </record>
 
@@ -28,16 +28,16 @@
         <field name="name">Tax Exemption Kind</field>
         <field name="type">ir.actions.act_window</field>
         <field name="res_model">account.tax.kind</field>
-        <field name="view_mode">tree,form</field>
+        <field name="view_mode">list,form</field>
         <field name="view_id" ref="view_account_tax_kind_tree" />
     </record>
 
-    <menuitem
-        id="account_tax_kind_menu"
-        parent="l10n_it_account.account_italian_localization"
-        name="Tax Exemption Kind"
-        action="view_account_tax_kind_action"
-        groups="account.group_account_manager"
-        sequence="40"
-    />
+<!--    <menuitem-->
+<!--        id="account_tax_kind_menu"-->
+<!--        parent="l10n_it_account.account_italian_localization"-->
+<!--        name="Tax Exemption Kind"-->
+<!--        action="view_account_tax_kind_action"-->
+<!--        groups="account.group_account_manager"-->
+<!--        sequence="40"-->
+<!--    />-->
 </odoo>

l10n_it_account_tax_kind/view/account_tax_view.xml

@@ -9,7 +9,8 @@
                 <field name="kind_id" />
                 <field
                     name="law_reference"
-                    attrs="{'required': [('kind_id', '!=', False),('type_tax_use', '!=', 'purchase')], 'invisible': [('type_tax_use', '=', 'purchase')]}"
+                    required="kind_id and type_tax_use != 'purchase'"
+                    invisible="type_tax_use == 'purchase'"
                 />
             </xpath>
         </field>