Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0] l10n_it_fatturapa_in - fattura con arrotondamento importata con dettaglio minimo #2107

Merged
merged 1 commit into from
Feb 27, 2021
Merged

[12.0] l10n_it_fatturapa_in - fattura con arrotondamento importata con dettaglio minimo #2107

merged 1 commit into from
Feb 27, 2021

Conversation

TheMule71
Copy link
Contributor

Risolve #2093.

Quando viene importata con dettaglio minimo la fattura non ha righe, la max() fallisce su recordset vuoto.

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

@Borruso
Copy link
Contributor

Borruso commented Feb 9, 2021

testata ok

SimoRubi
SimoRubi approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@SimoRubi SimoRubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie della PR!
Ho fatto review del codice e per me è ok.

Visto che chiaramente questo caso non era coperto da un test automatico, riesci ad aggiungerne uno?
Direi che potresti usare il file allegato alla issue come file di esempio.

Altrimenti, data l'entità della modifica, può andare bene anche così.

@eLBati
Copy link
Member

eLBati commented Feb 23, 2021

Un test automatico sarebbe ottimo

@TheMule71
[FIX] l10n_it_fatturapa_in: fattura con arrotondamento importata con …
eb67d3f 
…dettaglio minimo

Risolve OCA#2093.

Quando viene importata con dettaglio minimo la fattura non ha righe,
la max() fallisce su recordset vuoto.
@TheMule71
Copy link
Contributor Author

Un test automatico sarebbe ottimo

Obbedisco! :)

eLBati
eLBati approved these changes Feb 26, 2021
View reviewed changes
Copy link
Member

@eLBati eLBati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@eLBati
Copy link
Member

eLBati commented Feb 27, 2021

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-2107-by-eLBati-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 27, 2021
@OCA-git-bot
Merge PR #2107 into 12.0
7343e4a 
Signed-off-by eLBati
@eLBati eLBati mentioned this pull request Feb 27, 2021
Closed
3 tasks
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-2107-by-eLBati-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0d6c1b6 into OCA:12.0 Feb 27, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2cba836. Thanks a lot for contributing to OCA. ❤️

@TheMule71 TheMule71 deleted the 12.0-fatturapa-in-max-fix branch February 27, 2021 19:02
@TheMule71 TheMule71 mentioned this pull request May 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimoRubi SimoRubi SimoRubi approved these changes

@eLBati eLBati eLBati approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TheMule71 @Borruso @eLBati @OCA-git-bot @SimoRubi