Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][MIG] l10n_it_intrastat #2228

Merged
merged 42 commits into from
Nov 19, 2021
Merged

Conversation

SimoRubi
Copy link
Member

@SimoRubi SimoRubi commented Apr 22, 2021

@SimoRubi SimoRubi mentioned this pull request Apr 22, 2021
76 tasks
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Apr 23, 2021
@SimoRubi SimoRubi force-pushed the 14.0-mig-l10n_it_intrastat branch 2 times, most recently from 6a764aa to 7efd8ee Compare April 23, 2021 13:53
@SimoRubi SimoRubi marked this pull request as ready for review April 26, 2021 09:12
if country_id:
country_payment_id = country_id
elif self.move_id.is_purchase_document():
country_payment_id = self.invoice_id.partner_id.country_id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invoice_id va sostituito con move_id

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie, fatto

@TheMule71
Copy link
Contributor

Ciao,
vedo in giro ancora dei size= nei fields.Char()

@SimoRubi SimoRubi force-pushed the 14.0-mig-l10n_it_intrastat branch from 6825923 to a1e86e1 Compare May 6, 2021 07:59
@SimoRubi
Copy link
Member Author

SimoRubi commented May 6, 2021

Ciao,
vedo in giro ancora dei size= nei fields.Char()

Sì, a quanto vedo size è sempre stato deprecato fin da odoo/odoo@524bb0a ma funziona e non vedo una valida alternativa: si potrebbero aggiungere dei constraint ma mi pare essere moolto più developer-friendly un semplice size= nella definizione del campo; i constraint li vedo utili per gestire casi più complessi.
Dici che sono da togliere comunque?

TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jun 6, 2021
@SimoRubi SimoRubi force-pushed the 14.0-mig-l10n_it_intrastat branch from a1e86e1 to 9478485 Compare June 9, 2021 15:33
@SimoRubi SimoRubi marked this pull request as draft June 10, 2021 09:24
@SimoRubi SimoRubi force-pushed the 14.0-mig-l10n_it_intrastat branch 2 times, most recently from 22770f0 to 813b351 Compare June 14, 2021 14:23
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jun 18, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jun 18, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 2, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 2, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 9, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 9, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 9, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 9, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 9, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 9, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 9, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 9, 2021
Otherwise the following warning is raised:
unknown parameter 'size', if this is an actual parameter you may want to override the method _valid_field_parameter on the relevant model in order to allow it
Copy link
Contributor

@TheMule71 TheMule71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@tafaRU
Copy link
Member

tafaRU commented Nov 15, 2021

Mergi tu @TheMule71?

@TheMule71
Copy link
Contributor

/ocabot merge nobump

@tafaRU
Copy link
Member

tafaRU commented Nov 18, 2021

@TheMule71 il tuo merge non è andato a buon fine: puoi riprovare? Considerato che ci sono altri commit dopo quello di merge, non userei l'opzione nobump ma almeno patch, che ne pensi?

@AntonioMariaVigliotti
Copy link

Ho creato un cliente tedesco e ho creato una fattura di 5 righe:
2 prodotti intrastat che sono correttamente riportati nella lista intrastat
1 prodotto escluso che non è correttamente riportato nella lista intrastat
1 prodotto di servizio che è correttamente riportato nella lista intrastat
1 prodotto misto ripartito sui prodotti precedenti

Visualizzazione dati Intrastat in fattura molto brutta, quasi iilleggibile

Da tradurre:

  • Magazzino > Prodotti > Tipo intrastat

Per me Ok
+1

Copy link

@AntonioMariaVigliotti AntonioMariaVigliotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test superati
Ringrazio lo sviluppatore il lavoro fatto

@TheMule71
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-2228-by-TheMule71-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 19, 2021
Signed-off-by TheMule71
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-2228-by-TheMule71-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit bc36628 into OCA:14.0 Nov 19, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 62424a5. Thanks a lot for contributing to OCA. ❤️

@tafaRU
Copy link
Member

tafaRU commented Nov 19, 2021

/ocabot migration l10n_it_intrastat

@OCA-git-bot OCA-git-bot added this to the 14.0 milestone Nov 19, 2021
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Jan 21, 2022
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Jan 21, 2022
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.