Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX] l10n_it_fatturapa_in: Fixed singleton error on field computation #2355

Merged
merged 1 commit into from
Jul 23, 2021
Merged

[14.0][FIX] l10n_it_fatturapa_in: Fixed singleton error on field computation #2355

merged 1 commit into from
Jul 23, 2021

Conversation

TheMule71
Copy link
Contributor

Taking over #2350

Fixes: #2349

diff from #2350 (due to pre-commit formatting)

index 998191db7..7f7dafc99 100644
--- a/l10n_it_fatturapa_in/models/account.py
+++ b/l10n_it_fatturapa_in/models/account.py
@@ -247,10 +247,12 @@ class AccountInvoice(models.Model):
             bill.e_invoice_validation_message = ",\n".join(error_messages) + "."
             other_account_moves -= bill
 
-        other_account_moves.write({
-            'e_invoice_validation_error': False,
-            'e_invoice_validation_message': False,
-        })
+        other_account_moves.write(
+            {
+                "e_invoice_validation_error": False,
+                "e_invoice_validation_message": False,
+            }
+        )
 
     def name_get(self):
         result = super(AccountInvoice, self).name_get()

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

@TheMule71 TheMule71 mentioned this pull request Jul 2, 2021
Closed
SimoRubi
SimoRubi suggested changes Jul 12, 2021
View reviewed changes
l10n_it_fatturapa_in/models/account.py
@@ -174,9 +174,7 @@ def e_inv_dati_ritenuta(self):
"invoice_date",
)
def _compute_e_invoice_validation_error(self):
self.ensure_one()
self.e_invoice_validation_error = False
self.e_invoice_validation_message = False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Da odoo/odoo@9920f20 è possibile assegnare un valore ad un campo per più record, quindi per risolvere il problema credo sia sufficente rimuovere self.ensure_one, puoi provare?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funziona. Ho anche aggiunto un piccolo test, provato prima e dopo la patch.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie, puoi dare un nome più significativo al test e/o aggiungere una docstring?
test_2349_fix non fa capire cosa dovrebbe testare.

@TheMule71 TheMule71 force-pushed the 14.0-fix-l10n_it_fatturapa_in-singleton-error branch from 686c5f1 to 760f584 Compare July 16, 2021 08:41
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 17, 2021
@TheMule71
merged OCA#2354 OCA#2364, fixes OCA#2327 OCA#2332 OCA#2344 OCA#2355 O…
244c943 
…CA#2358 OCA#2360 OCA#2364
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 18, 2021
@TheMule71
merged OCA#2337 OCA#2354 OCA#2364, fixes OCA#2327 OCA#2332 OCA#2344 O…
d526885 
…CA#2355 OCA#2358 OCA#2360 OCA#2364
@TheMule71 TheMule71 requested a review from SimoRubi July 19, 2021 08:36
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 20, 2021
@TheMule71
merged OCA#2337 OCA#2354 OCA#2364, fixes OCA#2327 OCA#2332 OCA#2344 O…
6b8fd65 
…CA#2355 OCA#2358 OCA#2360 OCA#2364
@TheMule71 TheMule71 force-pushed the 14.0-fix-l10n_it_fatturapa_in-singleton-error branch from 760f584 to 0eefd4e Compare July 23, 2021 08:38
@tafaRU
Copy link
Member

tafaRU commented Jul 23, 2021

@SimoRubi puoi controllare se ora è ok?

SimoRubi
SimoRubi approved these changes Jul 23, 2021
View reviewed changes
Copy link
Member

@SimoRubi SimoRubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revisione del codice, per me è ok

@tafaRU
Copy link
Member

tafaRU commented Jul 23, 2021

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-2355-by-tafaRU-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit df4acb6 into OCA:14.0 Jul 23, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 47dcf67. Thanks a lot for contributing to OCA. ❤️

TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 30, 2021
@TheMule71
norebase OCA#2285, merged OCA#2336, OCA#2355, conflicts OCA#2327
d1ef3a0
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 30, 2021
@TheMule71
merged OCA#2337 OCA#2354 OCA#2364, fixes OCA#2327 OCA#2332 OCA#2344 O…
1bbcab8 
…CA#2355 OCA#2358 OCA#2360 OCA#2364
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 30, 2021
@TheMule71
merged OCA#2337 OCA#2354 OCA#2364, fixes OCA#2327 OCA#2332 OCA#2344 O…
5aa771a 
…CA#2355 OCA#2358 OCA#2360 OCA#2364
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 30, 2021
@TheMule71
norebase OCA#2285, merged OCA#2336, OCA#2355, conflicts OCA#2327
5b9a20f
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Aug 6, 2021
@TheMule71
merged OCA#2337 OCA#2354 OCA#2364, fixes OCA#2327 OCA#2332 OCA#2344 O…
30ddf57 
…CA#2355 OCA#2358 OCA#2360 OCA#2364
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Aug 6, 2021
@TheMule71
norebase OCA#2285, merged OCA#2336, OCA#2355, conflicts OCA#2327
6e4b8f3
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Aug 20, 2021
@TheMule71
merged OCA#2337 OCA#2354 OCA#2364, fixes OCA#2327 OCA#2332 OCA#2344 O…
f6ee610 
…CA#2355 OCA#2358 OCA#2360 OCA#2364
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Aug 20, 2021
@TheMule71
norebase OCA#2285, merged OCA#2336, OCA#2355, conflicts OCA#2327
be3d3ef
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Sep 3, 2021
@TheMule71
merged OCA#2337 OCA#2354 OCA#2364, fixes OCA#2327 OCA#2332 OCA#2344 O…
2432d0b 
…CA#2355 OCA#2358 OCA#2360 OCA#2364
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Sep 3, 2021
@TheMule71
norebase OCA#2285, merged OCA#2336, OCA#2355, conflicts OCA#2327
fc44728
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Sep 17, 2021
@TheMule71
merged OCA#2337 OCA#2354 OCA#2364, fixes OCA#2327 OCA#2332 OCA#2344 O…
7c6e02c 
…CA#2355 OCA#2358 OCA#2360 OCA#2364
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Sep 17, 2021
@TheMule71
norebase OCA#2285, merged OCA#2336, OCA#2355, conflicts OCA#2327
39dbfd8
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 1, 2021
@TheMule71
merged OCA#2337 OCA#2354 OCA#2364, fixes OCA#2327 OCA#2332 OCA#2344 O…
eec3877 
…CA#2355 OCA#2358 OCA#2360 OCA#2364
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 1, 2021
@TheMule71
norebase OCA#2285, merged OCA#2336, OCA#2355, conflicts OCA#2327
6d2b5ae
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 8, 2021
@TheMule71
merged OCA#2337 OCA#2354 OCA#2364, fixes OCA#2327 OCA#2332 OCA#2344 O…
c606f8b 
…CA#2355 OCA#2358 OCA#2360 OCA#2364
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 8, 2021
@TheMule71
norebase OCA#2285, merged OCA#2336, OCA#2355, conflicts OCA#2327
5df95f6
@TheMule71 TheMule71 deleted the 14.0-fix-l10n_it_fatturapa_in-singleton-error branch October 15, 2021 16:21
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 15, 2021
@TheMule71
merged OCA#2337 OCA#2354 OCA#2364, fixes OCA#2327 OCA#2332 OCA#2344 O…
a667e62 
…CA#2355 OCA#2358 OCA#2360 OCA#2364
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 15, 2021
@TheMule71
norebase OCA#2285, merged OCA#2336, OCA#2355, conflicts OCA#2327
04c3c13
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Jan 21, 2022
@TheMule71
merged OCA#2337 OCA#2354 OCA#2364, fixes OCA#2327 OCA#2332 OCA#2344 O…
934c1b2 
…CA#2355 OCA#2358 OCA#2360 OCA#2364
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Jan 21, 2022
@TheMule71
norebase OCA#2285, merged OCA#2336, OCA#2355, conflicts OCA#2327
227d891
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Jan 21, 2022
@TheMule71
merged OCA#2337 OCA#2354 OCA#2364, fixes OCA#2327 OCA#2332 OCA#2344 O…
dd195fa 
…CA#2355 OCA#2358 OCA#2360 OCA#2364
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Jan 21, 2022
@TheMule71
norebase OCA#2285, merged OCA#2336, OCA#2355, conflicts OCA#2327
ab0cb7c
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jun 29, 2022
@TheMule71
merged OCA#2337 OCA#2354 OCA#2364, fixes OCA#2327 OCA#2332 OCA#2344 O…
edf1cc8 
…CA#2355 OCA#2358 OCA#2360 OCA#2364
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jun 29, 2022
@TheMule71
norebase OCA#2285, merged OCA#2336, OCA#2355, conflicts OCA#2327
984e43b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimoRubi SimoRubi SimoRubi approved these changes

@tafaRU tafaRU tafaRU approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TheMule71 @tafaRU @OCA-git-bot @SimoRubi