Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0] FIX l10n_it_fatturapa_in EmailType pattern constraint violated by value www.example.com / info@yourcompany.example.com #2357

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

eLBati
Copy link
Member

@eLBati eLBati commented Jul 5, 2021

Lo schema
https://www.fatturapa.gov.it/export/documenti/fatturapa/v1.2.1/Schema_del_file_xml_FatturaPA_versione_1.2.xsd
contiene in effetti .+@.+[.]+.+, non so da quando

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

@eLBati
Copy link
Member Author

eLBati commented Jul 5, 2021

@TheMule71 secondo te capita anche su 14?

@TheMule71
Copy link
Contributor

TheMule71 commented Jul 18, 2021

@TheMule71 secondo te capita anche su 14?

Capita, capita. :)
Piuttosto, non conviene prendere l'ultima versione del file in toto, invece di cambiare solo la RE? #2367

A proposito, ho fatto un dos2unix perché così era il file nel repo (altrimenti sarebbe saltato fuori un mega diff di ogni riga). Così il diff ha senso.

Detto questo, io sono per tenere i file di specifica il più possibile originali, per cui (passata questa PR) lo metterei identico a quello che ti arriva da un wget.

https://www.fatturapa.gov.it/it/norme-e-regole/documentazione-fattura-elettronica/formato-fatturapa/
https://www.fatturapa.gov.it/export/documenti/fatturapa/v1.2.1/Schema_del_file_xml_FatturaPA_versione_1.2.1.xsd

TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 20, 2021
@eLBati
Copy link
Member Author

eLBati commented Jul 21, 2021

Piuttosto, non conviene prendere l'ultima versione del file in toto, invece di cambiare solo la RE?

E quindi rigenerare i bindings di pyxb di conseguenza, giusto?

Visto che pyxb comunque lo dismettiamo, ho pensato di non dedicarci troppo tempo, facendo solo questa hotfix

@TheMule71
Copy link
Contributor

Piuttosto, non conviene prendere l'ultima versione del file in toto, invece di cambiare solo la RE?

E quindi rigenerare i bindings di pyxb di conseguenza, giusto?

Visto che pyxb comunque lo dismettiamo, ho pensato di non dedicarci troppo tempo, facendo solo questa hotfix

In effetti andrebbero rigenerati i bindings, in teoria.

In pratica, da quello che vedo, l'unico problema con questa hotfix è che potenzialmente potremmo generare XML non conformi all'xsd, relavamente al campo:

<xs:element name="PECDestinatario" type="EmailType" minOccurs="0"/>

che rimane di EmailType e non EmailContattiType.

TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 30, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 30, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Aug 6, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Aug 9, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Aug 20, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Sep 3, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Sep 17, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 1, 2021
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Oct 2, 2021
@eLBati
Copy link
Member Author

eLBati commented Oct 12, 2021

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-2357-by-eLBati-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5ba7659 into OCA:12.0 Oct 12, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 75a45b8. Thanks a lot for contributing to OCA. ❤️

TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Nov 10, 2022
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Nov 11, 2022
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Nov 11, 2022
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Nov 11, 2022
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Nov 25, 2022
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Nov 25, 2022
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Dec 6, 2022
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Dec 15, 2022
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Dec 15, 2022
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Dec 16, 2022
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Dec 16, 2022
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Dec 30, 2022
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Jan 5, 2023
TonyMasciI pushed a commit to saydigital/l10n-italy that referenced this pull request Jan 9, 2023
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Jan 13, 2023
TonyMasciI pushed a commit to saydigital/l10n-italy that referenced this pull request Jan 16, 2023
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Jan 26, 2023
TonyMasciI pushed a commit to saydigital/l10n-italy that referenced this pull request Jan 27, 2023
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Feb 3, 2023
SirTakobi pushed a commit to SirTakobi/l10n-italy that referenced this pull request Feb 23, 2023
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Mar 5, 2023
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Mar 9, 2023
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Mar 17, 2023
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Mar 17, 2023
SirTakobi pushed a commit to SirTakobi/l10n-italy that referenced this pull request Mar 24, 2023
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Apr 6, 2023
are-agilebg pushed a commit to are-agilebg/l10n-italy that referenced this pull request May 10, 2023
are-agilebg pushed a commit to are-agilebg/l10n-italy that referenced this pull request May 10, 2023
are-agilebg pushed a commit to are-agilebg/l10n-italy that referenced this pull request May 10, 2023
are-agilebg pushed a commit to are-agilebg/l10n-italy that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants